Subject: CVS commit: pkgsrc/devel/libusb/patches
To: None <email@example.com>
From: Bernd Ernesti <firstname.lastname@example.org>
Date: 03/03/2002 17:20:11
Module Name: pkgsrc
Committed By: veego
Date: Sun Mar 3 15:20:11 UTC 2002
Patch from sourceforge (revision 1.12 of bsd.c):
Patch from seagull at aracnet.com:
Some time ago, I identified a problem with libusb under FreeBSD. The issue
is that the current implementation of bsd.c assumes that a particular
endpoint is unidirectional. If you write, for example, to endpoint 2,
you can't later on read from that same endpoint and visa-versa. Although
USB pipes are unidrectional, they can be "stacked" on the same endpoint.
Endpoint 2, for example, has two pipes: 0x02 and 0x82, with the high bit
representing the transfer direction of the pipe.
Since the BSD USB stack does not let you open two descriptors for the same
endpoint, and it does not let you close and reopen an endpoint in the middle
of a "session", I had originally proposed that the endpoint always be opened
O_RDWR so that bidirectional communication would be supported.
However, it was later pointed out that a device which really did only have a
unidrectional pipe on an endpoint would fail on ENXIO if you tried to open
it O_RDWR, so I went back to the drawing board and came up with a patch
for bsd.c which should solve the issue for both cases. What it does is
first attempt to open the endpoint O_RDWR. If that fails on ENXIO, then it
attempts to open the pipe in the direction appropriate for the operation
that you were committing.
To generate a diff of this commit:
cvs rdiff -r0 -r1.1 pkgsrc/devel/libusb/patches/patch-ad
Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.