Subject: Re: CVS commit: pkgsrc/mk
To: Todd Vierling <firstname.lastname@example.org>
From: Alistair Crooks <email@example.com>
Date: 10/01/2001 10:29:29
On Mon, Oct 01, 2001 at 07:16:45AM +0300, Todd Vierling wrote:
> Module Name: pkgsrc
> Committed By: tv
> Date: Mon Oct 1 04:16:44 UTC 2001
> Modified Files:
> pkgsrc/mk: bsd.pkg.defaults.mk
> Log Message:
> Don't set SU_CMD twice (the setting here was wrong anyway). The default
> may need to be platform-dependent, so let bsd.pkg.mk (not .defaults.mk
> set the default.
> To generate a diff of this commit:
> cvs rdiff -r1.4 -r1.5 pkgsrc/mk/bsd.pkg.defaults.mk
> Please note that diffs are not public domain; they are subject to the
> copyright notices on the relevant files.
Au contraire, the setting here was not wrong - it has been like
that for over two years, and no-one complained about it until you
modified the setting, without prior consultation, two months ago.
The bsd.pkg.defaults.mk setting was the same as was set in the old
mk.conf.example file, and is the correct one.
If you use a different setting in your environment, you are perfectly
free to set it in your own /etc/mk.conf.
I fail to see how any su(1) invocation could be platform-dependent,
since the pkgsrc implementation was developed on Solaris.
I shall revert the change you made to bsd.pkg.mk - if you disagree with
this, please start discussion on tech-pkg about it.