Hi Thomas!

I appreciate your steady maintenance work on pkgsrc, but this change (see
below) will actually *break* mpi-ch:

diff -u -r1.16 -r1.17
--- pkgsrc/parallel/mpi-ch/Makefile     2001/04/05 17:56:19     1.16
+++ pkgsrc/parallel/mpi-ch/Makefile     2001/04/09 12:00:49     1.17
@@ -1,4 +1,4 @@
-# $NetBSD: Makefile,v 1.16 2001/04/05 17:56:19 wennmach Exp $
+# $NetBSD: Makefile,v 1.17 2001/04/09 12:00:49 wiz Exp $

 DISTNAME=              mpich-1.2.1
 CATEGORIES=            parallel
@@ -26,14 +26,14 @@

 .include "../../mk/bsd.prefs.mk"

-.if exists(work/with-java)
+.if exists(${WRKDIR}/with-java)


The problem here is that variable expansion inside exists() does not work. I
don't know if this is a bug or a feature of make. Maybe I should file a PR,
what do people think?
With your change, this effectively is translated to .if exists(/with-java) and
that will fail.


 PLIST_SRC+=            ${PKGDIR}/PLIST.java
 .endif
 PLIST_SRC+=            ${PKGDIR}/PLIST

 post-build:
        @(if [ -e ${WRKSRC}/mpe/viewers/jumpshot-2/bin/jumpshot ]; then \
-               ${TOUCH} work/with-java; \
+               ${TOUCH} ${WRKDIR}/with-java; \
        fi)


This change is ok, but undesirable. Unless someone has a good idea how to solve
this problem, I'd prefer if you could undo this commit.

Thanks,
Lex

PS: I should have warned about this in a comment.


> Subject: CVS commit: pkgsrc
> To: None <pkgsrc-changes@netbsd.org>
> From: Thomas Klausner <wiz@netbsd.org>
> List: pkgsrc-changes
> Date: 04/09/2001 15:00:49
>
> Module Name:    pkgsrc
> Committed By:   wiz
> Date:           Mon Apr  9 12:00:49 UTC 2001
>
> Modified Files:
>         pkgsrc/parallel/mpi-ch: Makefile
>
> Log Message:
> replace work with ${WRKDIR}
>
>
> To generate a diff of this commit:
> cvs rdiff -r1.16 -r1.17 pkgsrc/parallel/mpi-ch/Makefile
>
> Please note that diffs are not public domain; they are subject to the
> copyright notices on the relevant files.