[pkgsrc/trunk]: pkgsrc/mail/isync Update to 1.4.3. From the changelog:

[schmonz <schmonz%pkgsrc.org@localhost>]

details:   https://anonhg.NetBSD.org/pkgsrc/rev/3a738700e215
branches:  trunk
changeset: 768330:3a738700e215
user:      schmonz <schmonz%pkgsrc.org@localhost>
date:      Tue Oct 19 11:23:16 2021 +0000

description:
Update to 1.4.3. From the changelog:

- limit maildir nesting depth
- enable embedding arbitrarily long strings into IMAP commands
- CVE-2021-3578: fix handling of unexpected APPENDUID response code
- don't crash on malformed CAPABILITY responses
- tolerate INBOX mis-casing in Path
- make UIDVALIDITY recovery more strict about vanished messages
- improve error messages about irrecoverably changed UIDVALIDITY
- CVE-2021-20247: reject funny mailbox names from IMAP LIST/LSUB
- be more tolerant of formally malformed response codes
- fix bogus continuation of IMAP list parsing
- accept unsolicited FETCH responses (without payload) after all
- use correct <poll.h> header

diffstat:

 mail/isync/Makefile                      |    5 +-
 mail/isync/distinfo                      |    9 +-
 mail/isync/patches/patch-src_drv__imap.c |  103 -------------------------------
 3 files changed, 6 insertions(+), 111 deletions(-)

diffs (136 lines):

diff -r f3abaa436fa8 -r 3a738700e215 mail/isync/Makefile
--- a/mail/isync/Makefile       Tue Oct 19 08:39:15 2021 +0000
+++ b/mail/isync/Makefile       Tue Oct 19 11:23:16 2021 +0000
@@ -1,7 +1,6 @@
-# $NetBSD: Makefile,v 1.52 2021/05/24 19:52:41 wiz Exp $
+# $NetBSD: Makefile,v 1.53 2021/10/19 11:23:16 schmonz Exp $
 
-DISTNAME=      isync-1.4.0
-PKGREVISION=   1
+DISTNAME=      isync-1.4.3
 CATEGORIES=    mail net
 MASTER_SITES=  ${MASTER_SITE_SOURCEFORGE:=isync/}
 
diff -r f3abaa436fa8 -r 3a738700e215 mail/isync/distinfo
--- a/mail/isync/distinfo       Tue Oct 19 08:39:15 2021 +0000
+++ b/mail/isync/distinfo       Tue Oct 19 11:23:16 2021 +0000
@@ -1,8 +1,7 @@
-$NetBSD: distinfo,v 1.22 2021/10/07 14:25:21 nia Exp $
+$NetBSD: distinfo,v 1.23 2021/10/19 11:23:16 schmonz Exp $
 
-RMD160 (isync-1.4.0.tar.gz) = 58e71c09c8757bb31b3bdbc5ecd4c9ca0e287e6c
-SHA512 (isync-1.4.0.tar.gz) = 6520bcfd9dc5d7c1d51d048c1814104815a3f76a3258ed79c06b22af07d4648340b1c4314175dc448bb109187c3af56565362c58fc744741b1806894e62374f5
-Size (isync-1.4.0.tar.gz) = 334991 bytes
+RMD160 (isync-1.4.3.tar.gz) = 6e72cdefb64f3f32642674e5cc2dcb52caabe4a0
+SHA512 (isync-1.4.3.tar.gz) = a026c07c8d84e4f488071c0ca9826c8710ec5cef51eeaa76d2261b99f6ab435e2d70008a5756890696824f2395c2a95aac861a11c954ca0e6f7416610fc74780
+Size (isync-1.4.3.tar.gz) = 337692 bytes
 SHA1 (patch-ae) = a3bdbdd05e32474bf76f8110561bdcea9b72b0c3
 SHA1 (patch-src_Makefile.in) = b989a7627dbb7c989dd26c3e20beeceb000a7a47
-SHA1 (patch-src_drv__imap.c) = d27230038c7442c6a0f63ccbb566b67cb1812632
diff -r f3abaa436fa8 -r 3a738700e215 mail/isync/patches/patch-src_drv__imap.c
--- a/mail/isync/patches/patch-src_drv__imap.c  Tue Oct 19 08:39:15 2021 +0000
+++ /dev/null   Thu Jan 01 00:00:00 1970 +0000
@@ -1,103 +0,0 @@
-$NetBSD: patch-src_drv__imap.c,v 1.2 2021/02/17 15:10:11 ryoon Exp $
-
-* Fix some runtime errors.
-  From upstream Git: 9e3041de9367113f3b2d7d7543d2eae4c78e2c67 to 95a83c8220861185906df5b38eed589984847bfb
-
---- src/drv_imap.c
-+++ src/drv_imap.c
-@@ -924,6 +924,7 @@ parse_imap_list( imap_store_t *ctx, char **sp, parse_list_state_t *sts )
-       }
-   bail:
-       free_list( sts->head );
-+      sts->level = 0;
-       return LIST_BAD;
- }
- 
-@@ -1181,7 +1182,8 @@ parse_fetch_rsp( imap_store_t *ctx, list_t *list, char *s ATTR_UNUSED )
-               for (cmdp = ctx->in_progress; cmdp; cmdp = cmdp->next)
-                       if (cmdp->param.uid == uid)
-                               goto gotuid;
--              goto badrsp;
-+              error( "IMAP error: unexpected FETCH response with BODY (UID %u)\n", uid );
-+              return LIST_BAD;
-         gotuid:
-               msgdata = ((imap_cmd_fetch_msg_t *)cmdp)->msg_data;
-               msgdata->data = body->val;
-@@ -1208,9 +1210,8 @@ parse_fetch_rsp( imap_store_t *ctx, list_t *list, char *s ATTR_UNUSED )
-                       memcpy( cur->tuid, tuid, TUIDL );
-               status &= ~(M_FLAGS | M_RECENT | M_SIZE | M_HEADER);
-       } else {
--        badrsp:
--              error( "IMAP error: unexpected FETCH response (UID %u)\n", uid );
--              return LIST_BAD;
-+              // These may come in as a result of STORE FLAGS despite .SILENT.
-+              status &= ~(M_FLAGS | M_RECENT);
-       }
- 
-       if (status) {
-@@ -1252,48 +1253,53 @@ parse_response_code( imap_store_t *ctx, imap_cmd_t *cmd, char *s )
-       if (!s || *s != '[')
-               return RESP_OK;         /* no response code */
-       s++;
--      if (!(p = strchr( s, ']' ))) {
--        bad_resp:
-+      if (!(arg = next_arg( &s ))) {
-               error( "IMAP error: malformed response code\n" );
-               return RESP_CANCEL;
-       }
--      *p++ = 0;
--      if (!(arg = next_arg( &s )))
--              goto bad_resp;
-       if (!strcmp( "UIDVALIDITY", arg )) {
-               if (!(arg = next_arg( &s )) ||
--                  (ctx->uidvalidity = strtoul( arg, &earg, 10 ), *earg))
-+                  (ctx->uidvalidity = strtoul( arg, &earg, 10 ), *earg != ']'))
-               {
-                       error( "IMAP error: malformed UIDVALIDITY status\n" );
-                       return RESP_CANCEL;
-               }
-       } else if (!strcmp( "UIDNEXT", arg )) {
-               if (!(arg = next_arg( &s )) ||
--                  (ctx->uidnext = strtoul( arg, &earg, 10 ), *earg))
-+                  (ctx->uidnext = strtoul( arg, &earg, 10 ), *earg != ']'))
-               {
-                       error( "IMAP error: malformed UIDNEXT status\n" );
-                       return RESP_CANCEL;
-               }
-       } else if (!strcmp( "CAPABILITY", arg )) {
-+              if (!(p = strchr( s, ']' ))) {
-+                      error( "IMAP error: malformed CAPABILITY status\n" );
-+                      return RESP_CANCEL;
-+              }
-+              *p = 0;
-               parse_capability( ctx, s );
--      } else if (!strcmp( "ALERT", arg )) {
-+      } else if (!strcmp( "ALERT]", arg )) {
-               /* RFC2060 says that these messages MUST be displayed
-                * to the user
-                */
--              for (; isspace( (uchar)*p ); p++);
--              error( "*** IMAP ALERT *** %s\n", p );
-+              if (!s) {
-+                      error( "IMAP error: malformed ALERT status\n" );
-+                      return RESP_CANCEL;
-+              }
-+              for (; isspace( (uchar)*s ); s++);
-+              error( "*** IMAP ALERT *** %s\n", s );
-       } else if (cmd && !strcmp( "APPENDUID", arg )) {
-               if (!(arg = next_arg( &s )) ||
-                   (ctx->uidvalidity = strtoul( arg, &earg, 10 ), *earg) ||
-                   !(arg = next_arg( &s )) ||
--                  (((imap_cmd_out_uid_t *)cmd)->out_uid = strtoul( arg, &earg, 10 ), *earg))
-+                  (((imap_cmd_out_uid_t *)cmd)->out_uid = strtoul( arg, &earg, 10 ), *earg != ']'))
-               {
-                       error( "IMAP error: malformed APPENDUID status\n" );
-                       return RESP_CANCEL;
-               }
-       } else if (!strcmp( "PERMANENTFLAGS", arg )) {
-               parse_list_init( &ctx->parse_list_sts );
--              if (parse_imap_list( NULL, &s, &ctx->parse_list_sts ) != LIST_OK) {
-+              if (parse_imap_list( NULL, &s, &ctx->parse_list_sts ) != LIST_OK || *s != ']') {
-                       error( "IMAP error: malformed PERMANENTFLAGS status\n" );
-                       return RESP_CANCEL;
-               }