pkgsrc-Changes-HG archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

[pkgsrc/trunk]: pkgsrc/pkgtools/pkglint/files All characters in PLIST files a...



details:   https://anonhg.NetBSD.org/pkgsrc/rev/2caa7ea29b43
branches:  trunk
changeset: 537008:2caa7ea29b43
user:      rillig <rillig%pkgsrc.org@localhost>
date:      Tue Jan 01 13:44:11 2008 +0000

description:
All characters in PLIST files are relevant, so make trailing white-space
an error. Who would ever want to install files whose name ends in
white-space?

diffstat:

 pkgtools/pkglint/files/pkglint.pl |  8 ++++++--
 1 files changed, 6 insertions(+), 2 deletions(-)

diffs (23 lines):

diff -r 85f9c5e233a5 -r 2caa7ea29b43 pkgtools/pkglint/files/pkglint.pl
--- a/pkgtools/pkglint/files/pkglint.pl Mon Dec 31 23:38:29 2007 +0000
+++ b/pkgtools/pkglint/files/pkglint.pl Tue Jan 01 13:44:11 2008 +0000
@@ -1,5 +1,5 @@
 #! @PERL@
-# $NetBSD: pkglint.pl,v 1.742 2007/12/22 22:27:17 rillig Exp $
+# $NetBSD: pkglint.pl,v 1.743 2008/01/01 13:44:11 rillig Exp $
 #
 
 # pkglint - static analyzer and checker for pkgsrc packages
@@ -7403,7 +7403,11 @@
        foreach my $line (@{$lines}) {
                my $text = $line->text;
 
-               checkline_trailing_whitespace($line);
+               if ($text =~ /\s$/) {
+                       $line->log_error("pkgsrc does not support filenames ending in white-space.");
+                       $line->explain_error(
+"Each character in the PLIST is relevant, even trailing white-space.");
+               }
 
                # @foo directives.
                if ($text =~ /^(?:\$\{[\w_]+\})?\@([a-z-]+)\s+(.*)/) {



Home | Main Index | Thread Index | Old Index