pkgsrc-Changes-HG archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

[pkgsrc/trunk]: pkgsrc/mk/check Refined the pattern for lines containing bad ...



details:   https://anonhg.NetBSD.org/pkgsrc/rev/a2f23bb152f6
branches:  trunk
changeset: 521367:a2f23bb152f6
user:      rillig <rillig%pkgsrc.org@localhost>
date:      Fri Nov 10 07:59:01 2006 +0000

description:
Refined the pattern for lines containing bad macros. White-space is
allowed between the "#" and the "define", and the value must be of the
form "${varname}/...", that is, starting with a double quote, followed
by "${" and a variable name, and directly behind the closing brace must
be a slash. This should catch most false positives while still being
useful.

diffstat:

 mk/check/check-headers.sh |  4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diffs (18 lines):

diff -r d4c41d502599 -r a2f23bb152f6 mk/check/check-headers.sh
--- a/mk/check/check-headers.sh Fri Nov 10 00:31:25 2006 +0000
+++ b/mk/check/check-headers.sh Fri Nov 10 07:59:01 2006 +0000
@@ -1,4 +1,4 @@
-# $NetBSD: check-headers.sh,v 1.7 2006/11/09 21:07:25 rillig Exp $
+# $NetBSD: check-headers.sh,v 1.8 2006/11/10 07:59:01 rillig Exp $
 #
 # This program checks the header files for possible problems.
 #
@@ -21,7 +21,7 @@
 
                # Check for "${" in macro definitions.
                case "$line" in
-               "#define"*"\"\${"[a-z]*"}"*"\""*)
+               "#"*define*\"\$\{[A-Za-z]*\}/*\"*)
                        found_unresolved_variable=yes
                        cs_error_heading "Found unresolved variable in macro:"
                        cs_error_msg "$fname: $line"



Home | Main Index | Thread Index | Old Index