[pkgsrc/trunk]: pkgsrc/pkgtools/pkglint/files Oops. The last change modified ...

[rillig <rillig%pkgsrc.org@localhost>]

details:   https://anonhg.NetBSD.org/pkgsrc/rev/5273758a1376
branches:  trunk
changeset: 508039:5273758a1376
user:      rillig <rillig%pkgsrc.org@localhost>
date:      Mon Feb 13 17:50:40 2006 +0000

description:
Oops. The last change modified the behavior of an if-then-elsif chain in a
way that I didn't intend. Fixed.

diffstat:

 pkgtools/pkglint/files/pkglint.pl |  12 +++++++-----
 1 files changed, 7 insertions(+), 5 deletions(-)

diffs (27 lines):

diff -r d14c83ee39db -r 5273758a1376 pkgtools/pkglint/files/pkglint.pl
--- a/pkgtools/pkglint/files/pkglint.pl Mon Feb 13 17:46:36 2006 +0000
+++ b/pkgtools/pkglint/files/pkglint.pl Mon Feb 13 17:50:40 2006 +0000
@@ -1,5 +1,5 @@
 #! @PERL@
-# $NetBSD: pkglint.pl,v 1.514 2006/02/13 15:37:49 rillig Exp $
+# $NetBSD: pkglint.pl,v 1.515 2006/02/13 17:50:40 rillig Exp $
 #
 
 # pkglint - static analyzer and checker for pkgsrc packages
@@ -3138,10 +3138,12 @@
                        $guessed = true;
                }
 
-               if (!defined($type) || $guessed) {
-                       if ($varname !~ qr"_MK$") {
-                               $opt_debug and $line->log_warning("[checkline_mk_vartype] Untyped variable ${varname}.");
-                       }
+               if ((!defined($type) || $guessed) && $varname !~ qr"^_MK$") {
+                       $opt_debug and $line->log_warning("[checkline_mk_vartype] Untyped variable ${varname}.");
+               }
+
+               if (!defined($type)) {
+                       # Cannot check anything if the type is not known.
 
                } elsif ($op eq "!=") {
                        $opt_debug and $line->log_info("Use of !=: ${value}");