pkgsrc-Changes-HG archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

[pkgsrc/trunk]: pkgsrc/pkgtools/pkglint/files - Variables whose name end in D...



details:   https://anonhg.NetBSD.org/pkgsrc/rev/e720d5aa7516
branches:  trunk
changeset: 507197:e720d5aa7516
user:      rillig <rillig%pkgsrc.org@localhost>
date:      Sun Jan 29 01:29:38 2006 +0000

description:
- Variables whose name end in DIR, DIRS, FILE, FILES, as well as PATH,
  PREFIX, LOCALBASE and PKGNAME may appear in single quotes.

diffstat:

 pkgtools/pkglint/files/pkglint.pl |  5 ++++-
 1 files changed, 4 insertions(+), 1 deletions(-)

diffs (20 lines):

diff -r 583f9090340e -r e720d5aa7516 pkgtools/pkglint/files/pkglint.pl
--- a/pkgtools/pkglint/files/pkglint.pl Sun Jan 29 01:21:45 2006 +0000
+++ b/pkgtools/pkglint/files/pkglint.pl Sun Jan 29 01:29:38 2006 +0000
@@ -1,5 +1,5 @@
 #! @PERL@
-# $NetBSD: pkglint.pl,v 1.495 2006/01/28 12:24:20 rillig Exp $
+# $NetBSD: pkglint.pl,v 1.496 2006/01/29 01:29:38 rillig Exp $
 #
 
 # pkglint - static analyzer and checker for pkgsrc packages
@@ -2243,6 +2243,9 @@
                        } elsif ($state == SWST_PLAIN && defined($mod) && $mod =~ qr":Q$") {
                                # Fine.
 
+                       } elsif ($state == SWST_SQUOT && $varname =~ qr"(?:DIRS?|FILES?|PATH|^PREFIX|^LOCALBASE|^PKGNAME)$") {
+                               # Fine, too.
+
                        } else {
                                $line->log_warning("Possibly misquoted make variable ${varname} in " . user_statename->[$state] . ".");
                                if ($state == SWST_PLAIN && !defined($mod)) {



Home | Main Index | Thread Index | Old Index