pkgsrc-Changes-HG archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

[pkgsrc/trunk]: pkgsrc/pkgtools/pkglint/files Removed the "Comment expected" ...



details:   https://anonhg.NetBSD.org/pkgsrc/rev/1cc41af6874e
branches:  trunk
changeset: 512544:1cc41af6874e
user:      rillig <rillig%pkgsrc.org@localhost>
date:      Thu May 11 11:03:16 2006 +0000

description:
Removed the "Comment expected" warning from patch files, as suggested by
many people on pkgsrcCon 2006.

diffstat:

 pkgtools/pkglint/files/pkglint.pl |  10 +++++-----
 1 files changed, 5 insertions(+), 5 deletions(-)

diffs (42 lines):

diff -r 5932eb5dcae2 -r 1cc41af6874e pkgtools/pkglint/files/pkglint.pl
--- a/pkgtools/pkglint/files/pkglint.pl Thu May 11 10:58:52 2006 +0000
+++ b/pkgtools/pkglint/files/pkglint.pl Thu May 11 11:03:16 2006 +0000
@@ -1,5 +1,5 @@
 #! @PERL@
-# $NetBSD: pkglint.pl,v 1.578 2006/05/11 09:16:53 rillig Exp $
+# $NetBSD: pkglint.pl,v 1.579 2006/05/11 11:03:16 rillig Exp $
 #
 
 # pkglint - static analyzer and checker for pkgsrc packages
@@ -4860,12 +4860,12 @@
                        #
                }], [PST_TEXT, re_patch_cfd, PST_CFA, sub() {
                        if (!$seen_comment) {
-                               $opt_warn_style and $line->log_warning("Comment expected.");
+                               #$opt_warn_style and $line->log_warning("Comment expected.");
                        }
                        $line->log_warning("Please use unified diffs (diff -u) for patches.");
                }], [PST_TEXT, re_patch_ufd, PST_UFA, sub() {
                        if (!$seen_comment) {
-                               $opt_warn_style and $line->log_warning("Comment expected.");
+                               #$opt_warn_style and $line->log_warning("Comment expected.");
                        }
                }], [PST_TEXT, re_patch_text, PST_TEXT, sub() {
                        $seen_comment = true;
@@ -4877,14 +4877,14 @@
                        if ($seen_comment) {
                                $opt_warn_space and $line->log_note("Empty line expected.");
                        } else {
-                               $opt_warn_style and $line->log_warning("Comment expected.");
+                               #$opt_warn_style and $line->log_warning("Comment expected.");
                        }
                        $line->log_warning("Please use unified diffs (diff -u) for patches.");
                }], [PST_CENTER, re_patch_ufd, PST_UFA, sub() {
                        if ($seen_comment) {
                                $opt_warn_space and $line->log_note("Empty line expected.");
                        } else {
-                               $opt_warn_style and $line->log_warning("Comment expected.");
+                               #$opt_warn_style and $line->log_warning("Comment expected.");
                        }
                }], [PST_CENTER, undef, PST_TEXT, sub() {
                        $opt_warn_space and $line->log_note("Empty line expected.");



Home | Main Index | Thread Index | Old Index