pkgsrc-Changes-HG archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

[pkgsrc/trunk]: pkgsrc/pkgtools/pkglint/files Added a check that suggests usi...



details:   https://anonhg.NetBSD.org/pkgsrc/rev/90749340762c
branches:  trunk
changeset: 519606:90749340762c
user:      rillig <rillig%pkgsrc.org@localhost>
date:      Fri Oct 06 18:58:55 2006 +0000

description:
Added a check that suggests using meta-pkgs/kde3/kde3.mk instead of
hand-tuning the directories where KDE files are installed.

diffstat:

 pkgtools/pkglint/files/pkglint.pl |  10 +++++++++-
 1 files changed, 9 insertions(+), 1 deletions(-)

diffs (25 lines):

diff -r 0768d21f6448 -r 90749340762c pkgtools/pkglint/files/pkglint.pl
--- a/pkgtools/pkglint/files/pkglint.pl Fri Oct 06 18:15:10 2006 +0000
+++ b/pkgtools/pkglint/files/pkglint.pl Fri Oct 06 18:58:55 2006 +0000
@@ -1,5 +1,5 @@
 #! @PERL@
-# $NetBSD: pkglint.pl,v 1.678 2006/10/05 21:09:31 rillig Exp $
+# $NetBSD: pkglint.pl,v 1.679 2006/10/06 18:58:55 rillig Exp $
 #
 
 # pkglint - static analyzer and checker for pkgsrc packages
@@ -5470,6 +5470,14 @@
                }
        }
 
+       if ($varname eq "CONFIGURE_ARGS" && $value =~ qr"=\$\{PREFIX\}/share/kde") {
+               $line->log_note("Please .include \"../../meta-pkgs/kde3/kde3.mk\" instead of this line.");
+               $line->explain_note(
+                       "That file probably does many things automatically and consistently that",
+                       "this package also does. When using kde3.mk, you can probably also leave",
+                       "out some explicit dependencies.");
+       }
+
        if ($varname eq "EVAL_PREFIX" && $value =~ qr"^([\w_]+)=") {
                my ($eval_varname) = ($1);
 



Home | Main Index | Thread Index | Old Index