pkgsrc-Changes-HG archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

[pkgsrc/trunk]: pkgsrc/games/rocksndiamonds-levels Extract to WRKSRC first so...



details:   https://anonhg.NetBSD.org/pkgsrc/rev/1b6400452a0c
branches:  trunk
changeset: 501207:1b6400452a0c
user:      reed <reed%pkgsrc.org@localhost>
date:      Tue Oct 18 20:22:17 2005 +0000

description:
Extract to WRKSRC first so permissions can be fixed.
Then use cpio to install.
I chose to do it this way although it can take over 10 minutes to install,
because users can modify levels and maliciously fill up disk space.
(Maybe there is some tar, pax, or cpio option to extract and not use
permissions in the file?)
Bump PKGREVISION.
Add LANGUAGES=     # none
And added a comment to this file about the score files:
what cleans them up?

diffstat:

 games/rocksndiamonds-levels/Makefile |  17 ++++++++++++-----
 1 files changed, 12 insertions(+), 5 deletions(-)

diffs (53 lines):

diff -r 42f9d3d2edfa -r 1b6400452a0c games/rocksndiamonds-levels/Makefile
--- a/games/rocksndiamonds-levels/Makefile      Tue Oct 18 20:18:24 2005 +0000
+++ b/games/rocksndiamonds-levels/Makefile      Tue Oct 18 20:22:17 2005 +0000
@@ -1,11 +1,13 @@
-# $NetBSD: Makefile,v 1.9 2005/10/18 20:18:24 reed Exp $
+# $NetBSD: Makefile,v 1.10 2005/10/18 20:22:17 reed Exp $
 
 DISTNAME=      rocksndiamonds-levels-1.0
+PKGREVISION=   1
 CATEGORIES=    games x11
 MASTER_SITES=  http://www.artsoft.org/RELEASES/unix/rocksndiamonds/levels/
 DISTFILES=     rockslevels-dx-1.0.tar.gz \
                rockslevels-emc-1.0.tar.gz \
                rockslevels-sp-1.0.tar.gz
+WRKSRC=                ${WRKDIR}/levels
 
 MAINTAINER=    tech-pkg%NetBSD.org@localhost
 HOMEPAGE=      http://www.artsoft.org/rocksndiamonds/levels.html
@@ -13,15 +15,21 @@
 
 DEPENDS+=      rocksndiamonds{,-sdl}>=1.4.0:../../games/rocksndiamonds
 
-EXTRACT_ONLY=  # empty
 NO_CONFIGURE=  yes
 NO_BUILD=      yes
+LANGUAGES=     # none
 
 PLIST_SRC=     ${WRKDIR}/PLIST PLIST
 
 # if you change SCORE_PATH, don't forget to change patch-aa, too
 SCORE_PATH=    ${VARBASE}/games/rocksndiamonds
 
+CPIO?=         cpio
+
+post-extract:
+       ${CHMOD} -R o-w ${WRKSRC}
+
+# XXX: how are these directories cleaned up?
 do-install:
 .for directory in dx_abd dx_achim_haertel \
        dx_bd4 dx_blunderdash dx_boulderdash5 dx_dc2classic dx_firefox1 \
@@ -66,9 +74,8 @@
                ${INSTALL_DATA_DIR} ${SCORE_PATH}/scores/${directory} \
                && ${CHMOD} 775 ${SCORE_PATH}/scores/${directory}
 .endfor
-.for levels in ${DISTFILES}
-       cd ${PREFIX}/share/rocksndiamonds && ${PAX} -O -zrf ${DISTDIR}/${levels}
-.endfor
+       cd ${WRKSRC} && ${FIND} DX_Boulderdash Emerald_Mine_Club Supaplex | \
+               ${CPIO} -p ${PREFIX}/share/rocksndiamonds/levels
        ${RM} -f ${WRKDIR}/PLIST
 .for levdir in DX_Boulderdash Emerald_Mine_Club Supaplex
        cd ${PREFIX} && \



Home | Main Index | Thread Index | Old Index