pkgsrc-Changes-HG archive
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]
[pkgsrc/trunk]: pkgsrc/pkgtools/pkglint/files Don't check the quoting in back...
details: https://anonhg.NetBSD.org/pkgsrc/rev/083412861d1b
branches: trunk
changeset: 509476:083412861d1b
user: rillig <rillig%pkgsrc.org@localhost>
date: Fri Mar 10 22:30:25 2006 +0000
description:
Don't check the quoting in backticks. This is a misdesign of pkglint.
diffstat:
pkgtools/pkglint/files/pkglint.pl | 6 +++++-
1 files changed, 5 insertions(+), 1 deletions(-)
diffs (21 lines):
diff -r b2cea8009ffc -r 083412861d1b pkgtools/pkglint/files/pkglint.pl
--- a/pkgtools/pkglint/files/pkglint.pl Fri Mar 10 22:29:44 2006 +0000
+++ b/pkgtools/pkglint/files/pkglint.pl Fri Mar 10 22:30:25 2006 +0000
@@ -1,5 +1,5 @@
#! @PERL@
-# $NetBSD: pkglint.pl,v 1.545 2006/03/09 17:34:17 rillig Exp $
+# $NetBSD: pkglint.pl,v 1.546 2006/03/10 22:30:25 rillig Exp $
#
# pkglint - static analyzer and checker for pkgsrc packages
@@ -2529,6 +2529,10 @@
if ($state == SWST_PLAIN && defined($mod) && $mod =~ qr":Q$") {
# Fine.
+ } elsif ($state == SWST_BACKT) {
+ # Don't check here, to avoid false positives
+ # for tool names.
+
} elsif (($state == SWST_SQUOT || $state == SWST_DQUOT) && $varname =~ qr"^(?:.*DIR|.*FILE|.*PATH|.*_VAR|PREFIX|.*BASE|PKGNAME)$") {
# This is ok if we don't allow these
# variables to have embedded [\$\\\"\'\`].
Home |
Main Index |
Thread Index |
Old Index