[pkgsrc/trunk]: pkgsrc/pkgtools/pkglint/files In pax(1) command lines, -pe is...

[rillig <rillig%pkgsrc.org@localhost>]

details:   https://anonhg.NetBSD.org/pkgsrc/rev/2265a774613a
branches:  trunk
changeset: 514550:2265a774613a
user:      rillig <rillig%pkgsrc.org@localhost>
date:      Wed Jun 14 07:44:30 2006 +0000

description:
In pax(1) command lines, -pe is deprecated in favor of -pp.

diffstat:

 pkgtools/pkglint/files/pkglint.pl |  10 +++++++++-
 1 files changed, 9 insertions(+), 1 deletions(-)

diffs (25 lines):

diff -r 9810807f8548 -r 2265a774613a pkgtools/pkglint/files/pkglint.pl
--- a/pkgtools/pkglint/files/pkglint.pl Wed Jun 14 07:29:41 2006 +0000
+++ b/pkgtools/pkglint/files/pkglint.pl Wed Jun 14 07:44:30 2006 +0000
@@ -1,5 +1,5 @@
 #! @PERL@
-# $NetBSD: pkglint.pl,v 1.619 2006/06/10 17:13:11 adrianp Exp $
+# $NetBSD: pkglint.pl,v 1.620 2006/06/14 07:44:30 rillig Exp $
 #
 
 # pkglint - static analyzer and checker for pkgsrc packages
@@ -3526,6 +3526,14 @@
                                "INSTALL_MAN_DIR, INSTALL_DATA_DIR.");
                }
 
+               if ($state == SCST_PAX && $shellword eq "-pe") {
+                       $line->log_warning("Please use the -pp option to pax(1) instead of -pe.");
+                       $line->explain_warning(
+                               "The -pe option tells pax to preserve the ownership of the files, which",
+                               "means that the installed files will belong to the user that has built",
+                               "the package. That's a Bad Thing.");
+               }
+
                if ($state == SCST_PAX_S || $state == SCST_SED_E) {
                        if (false && $shellword !~ qr"^[\"\'].*[\"\']$") {
                                $line->log_warning("Substitution commands like \"${shellword}\" should always be quoted.");