pkgsrc-Changes-HG archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

[pkgsrc/trunk]: pkgsrc/pkgtools/pkglint/files When it is not clear whether th...



details:   https://anonhg.NetBSD.org/pkgsrc/rev/cb4eba643de6
branches:  trunk
changeset: 513934:cb4eba643de6
user:      rillig <rillig%pkgsrc.org@localhost>
date:      Tue Jun 06 05:18:56 2006 +0000

description:
When it is not clear whether the :Q operator should be used or not,
return dont_know instead of true.

diffstat:

 pkgtools/pkglint/files/pkglint.pl |  9 +++------
 1 files changed, 3 insertions(+), 6 deletions(-)

diffs (24 lines):

diff -r e9b5f75cee57 -r cb4eba643de6 pkgtools/pkglint/files/pkglint.pl
--- a/pkgtools/pkglint/files/pkglint.pl Tue Jun 06 04:48:19 2006 +0000
+++ b/pkgtools/pkglint/files/pkglint.pl Tue Jun 06 05:18:56 2006 +0000
@@ -1,5 +1,5 @@
 #! @PERL@
-# $NetBSD: pkglint.pl,v 1.602 2006/06/05 22:34:40 rillig Exp $
+# $NetBSD: pkglint.pl,v 1.603 2006/06/06 05:18:56 rillig Exp $
 #
 
 # pkglint - static analyzer and checker for pkgsrc packages
@@ -2668,11 +2668,8 @@
                return false;
        }
 
-       $opt_debug and $line->log_note("Don't know whether :Q is needed for ${varname}.");
-
-       # For all other variables, assume that quoting is necessary.
-       # XXX: This can be improved.
-       return true;
+       $opt_debug_quoting and $line->log_debug("Don't know whether :Q is needed for ${varname}.");
+       return dont_know;
 }
 
 #



Home | Main Index | Thread Index | Old Index