[pkgsrc/trunk]: pkgsrc/mk Modify the barrier so that we always invoke the rec...

[jlam <jlam%pkgsrc.org@localhost>]

details:   https://anonhg.NetBSD.org/pkgsrc/rev/3dd4473fa74d
branches:  trunk
changeset: 516528:3dd4473fa74d
user:      jlam <jlam%pkgsrc.org@localhost>
date:      Sat Jul 22 16:31:35 2006 +0000

description:
Modify the barrier so that we always invoke the recursive make process
when passing through the barrier.  This ensures the PATH (passed via
PKGSRC_MAKE_ENV) is correctly set for all phases after the barrier.

This fixes a bug in "interactive" pkgsrc use, where if you have no
work directory and type "make build && make install", then the "install"
step does not have a PATH set to include all the wrapper and tools
directories.

diffstat:

 mk/bsd.pkg.barrier.mk           |  8 ++++----
 mk/build/bsd.build.mk           |  4 ++--
 mk/build/build.mk               |  4 ++--
 mk/build/test.mk                |  4 ++--
 mk/buildlink3/bsd.buildlink3.mk |  4 ++--
 mk/configure/bsd.configure.mk   |  4 ++--
 mk/configure/configure.mk       |  4 ++--
 mk/extract/extract.mk           |  4 ++--
 mk/install/bsd.install.mk       |  4 ++--
 mk/install/install.mk           |  4 ++--
 mk/install/replace.mk           |  4 ++--
 mk/package/bsd.package.mk       |  4 ++--
 mk/package/package.mk           |  4 ++--
 mk/patch/patch.mk               |  4 ++--
 mk/wrapper/bsd.wrapper.mk       |  4 ++--
 15 files changed, 32 insertions(+), 32 deletions(-)

diffs (284 lines):

diff -r 5855c242ccf6 -r 3dd4473fa74d mk/bsd.pkg.barrier.mk
--- a/mk/bsd.pkg.barrier.mk     Sat Jul 22 13:11:28 2006 +0000
+++ b/mk/bsd.pkg.barrier.mk     Sat Jul 22 16:31:35 2006 +0000
@@ -1,4 +1,4 @@
-# $NetBSD: bsd.pkg.barrier.mk,v 1.8 2006/07/21 14:27:56 jlam Exp $
+# $NetBSD: bsd.pkg.barrier.mk,v 1.9 2006/07/22 16:31:35 jlam Exp $
 
 _COOKIE.barrier=       ${WRKDIR}/.barrier_cookie
 
@@ -40,7 +40,7 @@
 ### target invokes a new make should be listed in _BARRIER_POST_TARGETS,
 ### and should be of the form:
 ###
-###    .if !exists(${_COOKIE.barrier})
+###    .if !defined(_PKGSRC_BARRIER)
 ###    foo: barrier
 ###    .else
 ###    foo: foo's real source dependencies
@@ -52,11 +52,11 @@
 
 .PHONY: barrier
 barrier: ${_BARRIER_PRE_TARGETS} ${_COOKIE.barrier}
-.if !exists(${_COOKIE.barrier})
+.if !defined(_PKGSRC_BARRIER)
 .  if defined(PKG_VERBOSE)
        @${PHASE_MSG} "Invoking \`\`"${_BARRIER_CMDLINE_TARGETS:Q}"'' after barrier for ${PKGNAME}"
 .  endif
-       ${_PKG_SILENT}${_PKG_DEBUG}cd ${.CURDIR} && ${SETENV} ${PKGSRC_MAKE_ENV} ${MAKE} ${MAKEFLAGS} ALLOW_VULNERABLE_PACKAGES= ${_BARRIER_CMDLINE_TARGETS}
+       ${_PKG_SILENT}${_PKG_DEBUG}cd ${.CURDIR} && ${SETENV} ${PKGSRC_MAKE_ENV} ${MAKE} ${MAKEFLAGS} _PKGSRC_BARRIER=yes ALLOW_VULNERABLE_PACKAGES= ${_BARRIER_CMDLINE_TARGETS}
 .  if defined(PKG_VERBOSE)
        @${PHASE_MSG} "Leaving \`\`"${_BARRIER_CMDLINE_TARGETS:Q}"'' after barrier for ${PKGNAME}"
 .  endif
diff -r 5855c242ccf6 -r 3dd4473fa74d mk/build/bsd.build.mk
--- a/mk/build/bsd.build.mk     Sat Jul 22 13:11:28 2006 +0000
+++ b/mk/build/bsd.build.mk     Sat Jul 22 16:31:35 2006 +0000
@@ -1,4 +1,4 @@
-# $NetBSD: bsd.build.mk,v 1.7 2006/07/07 21:24:28 jlam Exp $
+# $NetBSD: bsd.build.mk,v 1.8 2006/07/22 16:31:35 jlam Exp $
 #
 # This Makefile fragment is included by bsd.pkg.mk and provides all
 # variables and targets related to building sources for a package.
@@ -28,7 +28,7 @@
 .  if exists(${_COOKIE.build})
 build:
        @${DO_NADA}
-.  elif exists(${_COOKIE.barrier})
+.  elif defined(_PKGSRC_BARRIER)
 build: configure build-cookie pkginstall
 .  else
 build: barrier
diff -r 5855c242ccf6 -r 3dd4473fa74d mk/build/build.mk
--- a/mk/build/build.mk Sat Jul 22 13:11:28 2006 +0000
+++ b/mk/build/build.mk Sat Jul 22 16:31:35 2006 +0000
@@ -1,4 +1,4 @@
-# $NetBSD: build.mk,v 1.4 2006/07/07 21:24:28 jlam Exp $
+# $NetBSD: build.mk,v 1.5 2006/07/22 16:31:35 jlam Exp $
 #
 # BUILD_MAKE_FLAGS is the list of arguments that is passed to the make
 #      process.
@@ -26,7 +26,7 @@
 .  if exists(${_COOKIE.build})
 build:
        @${DO_NADA}
-.  elif exists(${_COOKIE.barrier})
+.  elif defined(_PKGSRC_BARRIER)
 build: ${_BUILD_TARGETS}
 .  else
 build: barrier
diff -r 5855c242ccf6 -r 3dd4473fa74d mk/build/test.mk
--- a/mk/build/test.mk  Sat Jul 22 13:11:28 2006 +0000
+++ b/mk/build/test.mk  Sat Jul 22 16:31:35 2006 +0000
@@ -1,4 +1,4 @@
-# $NetBSD: test.mk,v 1.5 2006/07/07 21:24:28 jlam Exp $
+# $NetBSD: test.mk,v 1.6 2006/07/22 16:31:35 jlam Exp $
 #
 # TEST_DIRS is the list of directories in which to perform the build
 #      process.  If the directories are relative paths, then they
@@ -30,7 +30,7 @@
 .  if exists(${_COOKIE.test})
 test:
        @${DO_NADA}
-.  elif exists(${_COOKIE.barrier})
+.  elif defined(_PKGSRC_BARRIER)
 test: ${_TEST_TARGETS}
 .  else
 test: barrier
diff -r 5855c242ccf6 -r 3dd4473fa74d mk/buildlink3/bsd.buildlink3.mk
--- a/mk/buildlink3/bsd.buildlink3.mk   Sat Jul 22 13:11:28 2006 +0000
+++ b/mk/buildlink3/bsd.buildlink3.mk   Sat Jul 22 16:31:35 2006 +0000
@@ -1,4 +1,4 @@
-# $NetBSD: bsd.buildlink3.mk,v 1.184 2006/07/10 17:10:18 wiz Exp $
+# $NetBSD: bsd.buildlink3.mk,v 1.185 2006/07/22 16:31:35 jlam Exp $
 #
 # Copyright (c) 2004 The NetBSD Foundation, Inc.
 # All rights reserved.
@@ -197,7 +197,7 @@
 ###
 ### BEGIN: after the barrier
 ###
-.if exists(${_COOKIE.barrier})
+.if defined(_PKGSRC_BARRIER)
 
 # Generate default values for:
 #
diff -r 5855c242ccf6 -r 3dd4473fa74d mk/configure/bsd.configure.mk
--- a/mk/configure/bsd.configure.mk     Sat Jul 22 13:11:28 2006 +0000
+++ b/mk/configure/bsd.configure.mk     Sat Jul 22 16:31:35 2006 +0000
@@ -1,4 +1,4 @@
-# $NetBSD: bsd.configure.mk,v 1.6 2006/07/07 21:24:28 jlam Exp $
+# $NetBSD: bsd.configure.mk,v 1.7 2006/07/22 16:31:35 jlam Exp $
 #
 # This Makefile fragment is included by bsd.pkg.mk and provides all
 # variables and targets related to configuring packages for building.
@@ -26,7 +26,7 @@
 .  if exists(${_COOKIE.configure})
 configure:
        @${DO_NADA}
-.  elif exists(${_COOKIE.barrier})
+.  elif defined(_PKGSRC_BARRIER)
 configure: wrapper configure-cookie
 .  else
 configure: barrier
diff -r 5855c242ccf6 -r 3dd4473fa74d mk/configure/configure.mk
--- a/mk/configure/configure.mk Sat Jul 22 13:11:28 2006 +0000
+++ b/mk/configure/configure.mk Sat Jul 22 16:31:35 2006 +0000
@@ -1,4 +1,4 @@
-# $NetBSD: configure.mk,v 1.7 2006/07/21 14:21:28 jlam Exp $
+# $NetBSD: configure.mk,v 1.8 2006/07/22 16:31:35 jlam Exp $
 #
 # CONFIGURE_SCRIPT is the path to the script to run in order to
 #      configure the software for building.  If the path is relative,
@@ -49,7 +49,7 @@
 .  if exists(${_COOKIE.configure})
 configure:
        @${DO_NADA}
-.  elif exists(${_COOKIE.barrier})
+.  elif defined(_PKGSRC_BARRIER)
 configure: ${_CONFIGURE_TARGETS}
 .  else
 configure: barrier
diff -r 5855c242ccf6 -r 3dd4473fa74d mk/extract/extract.mk
--- a/mk/extract/extract.mk     Sat Jul 22 13:11:28 2006 +0000
+++ b/mk/extract/extract.mk     Sat Jul 22 16:31:35 2006 +0000
@@ -1,4 +1,4 @@
-# $NetBSD: extract.mk,v 1.12 2006/07/21 14:21:28 jlam Exp $
+# $NetBSD: extract.mk,v 1.13 2006/07/22 16:31:35 jlam Exp $
 #
 # The following variables may be set by the package Makefile and
 # specify how extraction happens:
@@ -53,7 +53,7 @@
 .  if exists(${_COOKIE.extract})
 extract:
        @${DO_NADA}
-.  elif exists(${_COOKIE.barrier})
+.  elif defined(_PKGSRC_BARRIER)
 extract: ${_EXTRACT_TARGETS}
 .  else
 extract: barrier
diff -r 5855c242ccf6 -r 3dd4473fa74d mk/install/bsd.install.mk
--- a/mk/install/bsd.install.mk Sat Jul 22 13:11:28 2006 +0000
+++ b/mk/install/bsd.install.mk Sat Jul 22 16:31:35 2006 +0000
@@ -1,4 +1,4 @@
-# $NetBSD: bsd.install.mk,v 1.8 2006/07/07 21:24:28 jlam Exp $
+# $NetBSD: bsd.install.mk,v 1.9 2006/07/22 16:31:35 jlam Exp $
 #
 # This Makefile fragment is included by bsd.pkg.mk and provides all
 # variables and targets related to installing packages.
@@ -26,7 +26,7 @@
 .  if exists(${_COOKIE.install})
 install:
        @${DO_NADA}
-.  elif exists(${_COOKIE.barrier})
+.  elif defined(_PKGSRC_BARRIER)
 install: ${_PKGSRC_BUILD_TARGETS} install-cookie
 .  else
 install: barrier
diff -r 5855c242ccf6 -r 3dd4473fa74d mk/install/install.mk
--- a/mk/install/install.mk     Sat Jul 22 13:11:28 2006 +0000
+++ b/mk/install/install.mk     Sat Jul 22 16:31:35 2006 +0000
@@ -1,4 +1,4 @@
-# $NetBSD: install.mk,v 1.13 2006/07/20 14:17:48 jlam Exp $
+# $NetBSD: install.mk,v 1.14 2006/07/22 16:31:35 jlam Exp $
 
 ######################################################################
 ### install (PUBLIC)
@@ -17,7 +17,7 @@
 .  if exists(${_COOKIE.install})
 install:
        @${DO_NADA}
-.  elif exists(${_COOKIE.barrier})
+.  elif defined(_PKGSRC_BARRIER)
 install: ${_INSTALL_TARGETS}
 .  else
 install: barrier
diff -r 5855c242ccf6 -r 3dd4473fa74d mk/install/replace.mk
--- a/mk/install/replace.mk     Sat Jul 22 13:11:28 2006 +0000
+++ b/mk/install/replace.mk     Sat Jul 22 16:31:35 2006 +0000
@@ -1,4 +1,4 @@
-# $NetBSD: replace.mk,v 1.6 2006/07/07 21:24:28 jlam Exp $
+# $NetBSD: replace.mk,v 1.7 2006/07/22 16:31:35 jlam Exp $
 
 ######################################################################
 ### replace (PUBLIC)
@@ -12,7 +12,7 @@
 
 .PHONY: replace su-replace
 .if !target(replace)
-.  if exists(${_COOKIE.barrier})
+.  if defined(_PKGSRC_BARRIER)
 replace: ${_REPLACE_TARGETS} su-target
 .  else
 replace: barrier
diff -r 5855c242ccf6 -r 3dd4473fa74d mk/package/bsd.package.mk
--- a/mk/package/bsd.package.mk Sat Jul 22 13:11:28 2006 +0000
+++ b/mk/package/bsd.package.mk Sat Jul 22 16:31:35 2006 +0000
@@ -1,4 +1,4 @@
-# $NetBSD: bsd.package.mk,v 1.6 2006/07/07 21:24:28 jlam Exp $
+# $NetBSD: bsd.package.mk,v 1.7 2006/07/22 16:31:35 jlam Exp $
 #
 # This Makefile fragment is included by bsd.pkg.mk and provides all
 # variables and targets related to binary packages.
@@ -22,7 +22,7 @@
 .  if exists(${_COOKIE.package})
 package:
        @${DO_NADA}
-.  elif exists(${_COOKIE.barrier})
+.  elif defined(_PKGSRC_BARRIER)
 package: install
 .    if defined(SKIP_SILENT)
        @${DO_NADA}
diff -r 5855c242ccf6 -r 3dd4473fa74d mk/package/package.mk
--- a/mk/package/package.mk     Sat Jul 22 13:11:28 2006 +0000
+++ b/mk/package/package.mk     Sat Jul 22 16:31:35 2006 +0000
@@ -1,4 +1,4 @@
-# $NetBSD: package.mk,v 1.14 2006/07/07 21:24:28 jlam Exp $
+# $NetBSD: package.mk,v 1.15 2006/07/22 16:31:35 jlam Exp $
 
 ######################################################################
 ### package (PUBLIC)
@@ -21,7 +21,7 @@
 .  if exists(${_COOKIE.package})
 package:
        @${DO_NADA}
-.  elif exists(${_COOKIE.barrier})
+.  elif defined(_PKGSRC_BARRIER)
 package: ${_PACKAGE_TARGETS}
 .  else
 package: barrier
diff -r 5855c242ccf6 -r 3dd4473fa74d mk/patch/patch.mk
--- a/mk/patch/patch.mk Sat Jul 22 13:11:28 2006 +0000
+++ b/mk/patch/patch.mk Sat Jul 22 16:31:35 2006 +0000
@@ -1,4 +1,4 @@
-# $NetBSD: patch.mk,v 1.10 2006/07/21 14:21:28 jlam Exp $
+# $NetBSD: patch.mk,v 1.11 2006/07/22 16:31:35 jlam Exp $
 #
 # The following variables may be set in a package Makefile and control
 # how pkgsrc patches are applied.
@@ -63,7 +63,7 @@
 .  if exists(${_COOKIE.patch})
 patch:
        @${DO_NADA}
-.  elif exists(${_COOKIE.barrier})
+.  elif defined(_PKGSRC_BARRIER)
 patch: ${_PATCH_TARGETS}
 .  else
 patch: barrier
diff -r 5855c242ccf6 -r 3dd4473fa74d mk/wrapper/bsd.wrapper.mk
--- a/mk/wrapper/bsd.wrapper.mk Sat Jul 22 13:11:28 2006 +0000
+++ b/mk/wrapper/bsd.wrapper.mk Sat Jul 22 16:31:35 2006 +0000
@@ -1,4 +1,4 @@
-# $NetBSD: bsd.wrapper.mk,v 1.49 2006/07/21 14:21:28 jlam Exp $
+# $NetBSD: bsd.wrapper.mk,v 1.50 2006/07/22 16:31:35 jlam Exp $
 #
 # Copyright (c) 2005 The NetBSD Foundation, Inc.
 # All rights reserved.
@@ -780,7 +780,7 @@
 .  if exists(${_COOKIE.wrapper})
 wrapper:
        @${DO_NADA}
-.  elif exists(${_COOKIE.barrier})
+.  elif defined(_PKGSRC_BARRIER)
 wrapper: check-vulnerable tools acquire-wrapper-lock ${_COOKIE.wrapper} release-wrapper-lock
 .  else
 wrapper: barrier