pkgsrc-Changes-HG archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

[pkgsrc/trunk]: pkgsrc/pkgtools/pkglint/files Added but disabled a check that...



details:   https://anonhg.NetBSD.org/pkgsrc/rev/d5215f17bca0
branches:  trunk
changeset: 553616:d5215f17bca0
user:      rillig <rillig%pkgsrc.org@localhost>
date:      Mon Jan 26 15:44:15 2009 +0000

description:
Added but disabled a check that tests whether the PKGNAME and the
package directory match. There is much work to do until this can be
enabled.

diffstat:

 pkgtools/pkglint/files/pkglint.pl |  7 ++++++-
 1 files changed, 6 insertions(+), 1 deletions(-)

diffs (29 lines):

diff -r 9abf1bbba470 -r d5215f17bca0 pkgtools/pkglint/files/pkglint.pl
--- a/pkgtools/pkglint/files/pkglint.pl Mon Jan 26 15:43:09 2009 +0000
+++ b/pkgtools/pkglint/files/pkglint.pl Mon Jan 26 15:44:15 2009 +0000
@@ -1,5 +1,5 @@
 #! @PERL@
-# $NetBSD: pkglint.pl,v 1.797 2008/12/21 10:34:59 rillig Exp $
+# $NetBSD: pkglint.pl,v 1.798 2009/01/26 15:44:15 rillig Exp $
 #
 
 # pkglint - static analyzer and checker for pkgsrc packages
@@ -6886,6 +6886,10 @@
                : (undef, undef, undef, undef);
        if (defined($effective_pkgname_line)) {
                $opt_debug_misc and $effective_pkgname_line->log_debug("Effective name=${effective_pkgname} base=${effective_pkgbase} version=${effective_pkgversion}.");
+               # XXX: too many false positives
+               if (false && $pkgpath =~ m"/([^/]+)$" && $effective_pkgbase ne $1) {
+                       $effective_pkgname_line->log_warning("Mismatch between PKGNAME ($effective_pkgname) and package directory ($1).");
+               }
        }
 
        checkpackage_possible_downgrade();
@@ -7089,6 +7093,7 @@
        };
 
        my $transitions =
+               # [ from state, regex, to state, action ]
                [   [PST_START, re_patch_rcsid, PST_CENTER, sub() {
                        checkline_rcsid($line, "");
                }], [PST_START, undef, PST_CENTER, sub() {



Home | Main Index | Thread Index | Old Index