pkgsrc-Changes-HG archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

[pkgsrc/trunk]: pkgsrc/pkgtools/pkglint/files If, in a "case" statement of a ...



details:   https://anonhg.NetBSD.org/pkgsrc/rev/7c5ac54e4607
branches:  trunk
changeset: 516306:7c5ac54e4607
user:      rillig <rillig%pkgsrc.org@localhost>
date:      Tue Jul 18 21:13:22 2006 +0000

description:
If, in a "case" statement of a shell command, foo|bar appears, this is
not a pipe, so don't warn about an ignored exitcode.

diffstat:

 pkgtools/pkglint/files/pkglint.pl |  4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diffs (19 lines):

diff -r 6fc42d12b1d9 -r 7c5ac54e4607 pkgtools/pkglint/files/pkglint.pl
--- a/pkgtools/pkglint/files/pkglint.pl Tue Jul 18 20:57:31 2006 +0000
+++ b/pkgtools/pkglint/files/pkglint.pl Tue Jul 18 21:13:22 2006 +0000
@@ -1,5 +1,5 @@
 #! @PERL@
-# $NetBSD: pkglint.pl,v 1.656 2006/07/18 20:37:31 rillig Exp $
+# $NetBSD: pkglint.pl,v 1.657 2006/07/18 21:13:22 rillig Exp $
 #
 
 # pkglint - static analyzer and checker for pkgsrc packages
@@ -4273,7 +4273,7 @@
                        $line->log_warning("Please use \${ECHO_N} instead of \"echo -n\".");
                }
 
-               if ($opt_warn_extra && $shellword eq "|") {
+               if ($opt_warn_extra && $state != SCST_CASE_LABEL_CONT && $shellword eq "|") {
                        $line->log_warning("The exitcode of the left-hand-side command of the pipe operator is ignored.");
                        $line->explain_warning(
                                "If you need to detect the failure of the left-hand-side command, use",



Home | Main Index | Thread Index | Old Index