[pkgsrc/trunk]: pkgsrc/pkgtools/pkglint/files - Enabled the quoting warning f...

[rillig <rillig%pkgsrc.org@localhost>]

details:   https://anonhg.NetBSD.org/pkgsrc/rev/cacef4bcbea5
branches:  trunk
changeset: 505797:cacef4bcbea5
user:      rillig <rillig%pkgsrc.org@localhost>
date:      Sat Jan 07 23:29:23 2006 +0000

description:
- Enabled the quoting warning for SUBST_MESSAGE (this time the other
  direction: it had been quoted too much in the past).

diffstat:

 pkgtools/pkglint/files/pkglint.pl |  7 +------
 1 files changed, 1 insertions(+), 6 deletions(-)

diffs (25 lines):

diff -r e2d16e9650d3 -r cacef4bcbea5 pkgtools/pkglint/files/pkglint.pl
--- a/pkgtools/pkglint/files/pkglint.pl Sat Jan 07 23:27:41 2006 +0000
+++ b/pkgtools/pkglint/files/pkglint.pl Sat Jan 07 23:29:23 2006 +0000
@@ -1,5 +1,5 @@
 #! @PERL@ -w
-# $NetBSD: pkglint.pl,v 1.454 2006/01/07 20:00:00 rillig Exp $
+# $NetBSD: pkglint.pl,v 1.455 2006/01/07 23:29:23 rillig Exp $
 #
 
 # pkglint - static analyzer and checker for pkgsrc packages
@@ -2232,14 +2232,9 @@
                }
 
        } elsif ($type eq "SubstMessage") {
-
-# TODO: Enable this code when there is a :Q operator on the statement
-# that prints the ${SUBST_MESSAGE} in subst.mk.
-if (false) {
                if ($value =~ qr"^\".*\"$") {
                        $line->log_warning("${varname} should not be quoted.");
                }
-}
 
        } elsif ($type eq "Tool") {
                if ($value =~ qr"^([-\w]+|\[)(?::(\w+))?$") {