[pkgsrc/trunk]: pkgsrc/mk/scripts Added a few FIXMEs at places where this pro...

[rillig <rillig%pkgsrc.org@localhost>]

details:   https://anonhg.NetBSD.org/pkgsrc/rev/bcdbe259d954
branches:  trunk
changeset: 503321:bcdbe259d954
user:      rillig <rillig%pkgsrc.org@localhost>
date:      Fri Nov 18 11:07:27 2005 +0000

description:
Added a few FIXMEs at places where this program might fail unexpectedly.

diffstat:

 mk/scripts/mkdatabase |  6 +++++-
 1 files changed, 5 insertions(+), 1 deletions(-)

diffs (35 lines):

diff -r ccd351a1a4c2 -r bcdbe259d954 mk/scripts/mkdatabase
--- a/mk/scripts/mkdatabase     Fri Nov 18 10:58:37 2005 +0000
+++ b/mk/scripts/mkdatabase     Fri Nov 18 11:07:27 2005 +0000
@@ -1,5 +1,5 @@
 #!/bin/sh
-# $NetBSD: mkdatabase,v 1.8 2005/11/18 10:58:37 rillig Exp $
+# $NetBSD: mkdatabase,v 1.9 2005/11/18 11:07:27 rillig Exp $
 #
 # Script for generating a database with complete dependency information
 # for a particular package
@@ -139,6 +139,7 @@
 esac
 
 if [ ! -d "$TMPDIR" ]; then
+       # FIXME: wouldn't it be better to fail in this case?
        mkdir -p "$TMPDIR"
 fi
 
@@ -151,6 +152,8 @@
        ;;
 
     *)
+       # FIXME: wouldn't it be better to fail in this case?
+
        # make sure we have the full path to the database file
        DATABASE=`pwd`/${DATABASE}
        ;;
@@ -172,6 +175,7 @@
     case $debug_flag in
     yes)       echo "Looking for $pkgpath before appending";;
     esac
+    # FIXME: $pkgpath may contain special regex characters.
     if grep "^index $pkgpath " "${DATABASE}" >/dev/null 2>&1 ; then
        echo "$prompt $pkgpath has already been depended.  Skipping..."
        exit 0