[pkgsrc/trunk]: pkgsrc/multimedia/libdv This is to fix PR 30267. (I have noti...

[reed <reed%pkgsrc.org@localhost>]

details:   https://anonhg.NetBSD.org/pkgsrc/rev/e2c362955adf
branches:  trunk
changeset: 509517:e2c362955adf
user:      reed <reed%pkgsrc.org@localhost>
date:      Sat Mar 11 04:08:47 2006 +0000

description:
This is to fix PR 30267. (I have noticed same problem.)

The build needs optimization. So if CFLAGS doesn't contain at least
-O then add it. (Thank you Juan for idea.)

On the tech-pkg-ja%jp.NetBSD.org@localhost list, I was told (19 Dec 2005):

> This change can be accepted when judged only from my environment (i386),
> since the expression of "if empty(CFLAGS:M-O*)" is evaluated
> after setting of the environment variable (-O2).
> However, I do not have the positive proof whether this expression is evaluated
> after setting of the environment variable (-O2), in all environments.

So hopefully this doesn't break for anyone else.

diffstat:

 multimedia/libdv/Makefile.common |  5 ++++-
 1 files changed, 4 insertions(+), 1 deletions(-)

diffs (19 lines):

diff -r 94459f8a29a4 -r e2c362955adf multimedia/libdv/Makefile.common
--- a/multimedia/libdv/Makefile.common  Sat Mar 11 04:01:27 2006 +0000
+++ b/multimedia/libdv/Makefile.common  Sat Mar 11 04:08:47 2006 +0000
@@ -1,4 +1,4 @@
-# $NetBSD: Makefile.common,v 1.4 2006/03/09 21:04:45 jlam Exp $
+# $NetBSD: Makefile.common,v 1.5 2006/03/11 04:08:47 reed Exp $
 
 DISTNAME=      libdv-0.104
 CATEGORIES=    multimedia
@@ -30,6 +30,9 @@
 .endif
 
 LIBS+=         ${LIBOSSAUDIO}
+.if empty(CFLAGS:M-O*)
+CFLAGS+=       -O
+.endif
 
 .include "../../converters/libiconv/buildlink3.mk"
 .include "../../devel/gettext-lib/buildlink3.mk"