[pkgsrc/trunk]: pkgsrc/audio/spiralsynth The problem is that SpiralSynth open...

[ben <ben%pkgsrc.org@localhost>]

details:   https://anonhg.NetBSD.org/pkgsrc/rev/f40f443dbf29
branches:  trunk
changeset: 492971:f40f443dbf29
user:      ben <ben%pkgsrc.org@localhost>
date:      Sun Apr 24 03:29:11 2005 +0000

description:
The problem is that SpiralSynth opens the MIDI device path before
calling SetDeviceName.

The call trace goes something like this:

Synth.C
main() ==> Synth *synth=new Synth; ==> Synth::Synth()
==> MidiDevice::Get()->SetDeviceName(SpiralInfo::MIDIFILE);

SpiralSound/Midi.h
MidiDevice::Get() ==> m_Singleton=new MidiDevice;
==> MidiDevice::MidiDevice() ==> MidiDevice::Open()
==> MidiDevice::SetDeviceName

patches/patch-ao works around this problem by closing the prematurely
opened private variable representing the MIDI device, and setting it to
NULL.  MidiDevice methods check for NULL and re-initialize the private
variable, this time opening the MIDI device path after SetDeviceName.

diffstat:

 audio/spiralsynth/distinfo         |   3 ++-
 audio/spiralsynth/patches/patch-ao |  12 ++++++++++++
 2 files changed, 14 insertions(+), 1 deletions(-)

diffs (30 lines):

diff -r 04e22795d8e5 -r f40f443dbf29 audio/spiralsynth/distinfo
--- a/audio/spiralsynth/distinfo        Sun Apr 24 03:07:36 2005 +0000
+++ b/audio/spiralsynth/distinfo        Sun Apr 24 03:29:11 2005 +0000
@@ -1,4 +1,4 @@
-$NetBSD: distinfo,v 1.8 2005/02/23 20:39:52 agc Exp $
+$NetBSD: distinfo,v 1.9 2005/04/24 03:29:11 ben Exp $
 
 SHA1 (SpiralSynth-2.0.0.tar.gz) = ea42c5b7710237139f5281cf0c4ca155c184c4cd
 RMD160 (SpiralSynth-2.0.0.tar.gz) = c05f38a9ae8b8b87f520c11854631e6dfa00c034
@@ -16,3 +16,4 @@
 SHA1 (patch-al) = 7436bce933cbddcd4f869ab2cbbe27762d4273e5
 SHA1 (patch-am) = 4899c78015028a6e8047e5527362646e40a10708
 SHA1 (patch-an) = b99c57cd7aa4d5c95bbeffea6c992e9cd7b7c414
+SHA1 (patch-ao) = 138f58bd7fae0226690747efcb8daf472e3a5337
diff -r 04e22795d8e5 -r f40f443dbf29 audio/spiralsynth/patches/patch-ao
--- /dev/null   Thu Jan 01 00:00:00 1970 +0000
+++ b/audio/spiralsynth/patches/patch-ao        Sun Apr 24 03:29:11 2005 +0000
@@ -0,0 +1,12 @@
+$NetBSD: patch-ao,v 1.1 2005/04/24 03:29:11 ben Exp $
+
+--- Synth.C.orig       2002-06-11 15:09:42.000000000 -0700
++++ Synth.C
+@@ -82,6 +82,7 @@ m_OutGUI(OSSOutput::Get())
+       LoadPatch(1);
+       
+       MidiDevice::Get()->SetDeviceName(SpiralInfo::MIDIFILE);
++      MidiDevice::Get()->PackUpAndGoHome();
+ }
+ 
+ Synth::~Synth()