[pkgsrc/trunk]: pkgsrc/comms/fidogate Update fidogate to 4.4.9nb1. Extremely...

[tv <tv%pkgsrc.org@localhost>]

details:   https://anonhg.NetBSD.org/pkgsrc/rev/477c827af950
branches:  trunk
changeset: 479834:477c827af950
user:      tv <tv%pkgsrc.org@localhost>
date:      Mon Aug 23 15:18:02 2004 +0000

description:
Update fidogate to 4.4.9nb1.  Extremely minor changes from 4.4.5, mainly
changes local to the author's system and changes in doc to note better
the newer home on SourceForge.

However, this does contain a quasi-security fix:  LOGFILE and
FIDOGATE_LOGFILE could have been used to alter files owned by user/group
"news".  This is fixed in 4.4.9nb1, and will also be fixed in 4.4.10 from
the author.

diffstat:

 comms/fidogate/Makefile         |   5 +++--
 comms/fidogate/distinfo         |  26 +++++++++++++-------------
 comms/fidogate/patches/patch-aa |  21 ++++++++++++---------
 comms/fidogate/patches/patch-ac |  20 ++++++++++----------
 comms/fidogate/patches/patch-al |  25 +++++++++++++++++++------
 comms/fidogate/patches/patch-am |  19 +++++++++++--------
 comms/fidogate/patches/patch-an |  18 ++++++++++--------
 comms/fidogate/patches/patch-ao |  24 +++++++++++++++---------
 comms/fidogate/patches/patch-ap |  18 ++++++++++++------
 comms/fidogate/patches/patch-aq |  10 ++++++----
 comms/fidogate/patches/patch-at |   9 +++++----
 comms/fidogate/patches/patch-au |   9 +++++----
 12 files changed, 121 insertions(+), 83 deletions(-)

diffs (truncated from 418 to 300 lines):

diff -r afa5fabc53e8 -r 477c827af950 comms/fidogate/Makefile
--- a/comms/fidogate/Makefile   Mon Aug 23 14:50:04 2004 +0000
+++ b/comms/fidogate/Makefile   Mon Aug 23 15:18:02 2004 +0000
@@ -1,7 +1,8 @@
-# $NetBSD: Makefile,v 1.33 2004/04/24 02:05:31 tv Exp $
+# $NetBSD: Makefile,v 1.34 2004/08/23 15:18:02 tv Exp $
 #
 
-DISTNAME=      fidogate-4.4.5
+DISTNAME=      fidogate-4.4.9
+PKGREVISION=   1
 CATEGORIES=    comms
 MASTER_SITES=  ${MASTER_SITE_SOURCEFORGE:=fidogate/}
 
diff -r afa5fabc53e8 -r 477c827af950 comms/fidogate/distinfo
--- a/comms/fidogate/distinfo   Mon Aug 23 14:50:04 2004 +0000
+++ b/comms/fidogate/distinfo   Mon Aug 23 15:18:02 2004 +0000
@@ -1,10 +1,10 @@
-$NetBSD: distinfo,v 1.6 2003/10/10 09:02:44 rtr Exp $
+$NetBSD: distinfo,v 1.7 2004/08/23 15:18:02 tv Exp $
 
-SHA1 (fidogate-4.4.5.tar.gz) = ba69cb041d45f10f732f7d6399deeb5002f7d7ac
-Size (fidogate-4.4.5.tar.gz) = 1171414 bytes
-SHA1 (patch-aa) = 0bc06682bdddd8f7c47063bd22f7d70053c46f1a
+SHA1 (fidogate-4.4.9.tar.gz) = 7d23802931a67b5b3cc256f5dd85d8b2c47ab4fe
+Size (fidogate-4.4.9.tar.gz) = 1186562 bytes
+SHA1 (patch-aa) = a12ffe978a32b342a48927b2887b4c5340816c5c
 SHA1 (patch-ab) = 27457fff799208f3daf72eabb6a7b0b056faf945
-SHA1 (patch-ac) = b93a8656afea504e00692d4a235f117dfb67df68
+SHA1 (patch-ac) = 89e81b49da503eaaf6b641231d30cf75e58b376b
 SHA1 (patch-ad) = 2562aca505a403e9cd5e493fcf84f9c7b15e764f
 SHA1 (patch-ae) = e2cf8add74b051111626230257c01793c1c20ca9
 SHA1 (patch-af) = 7fbc604c555f210aa49de2ecc1ec13d9835287f0
@@ -13,13 +13,13 @@
 SHA1 (patch-ai) = 7d3c184bc1071a6e70be67707181650468557cc5
 SHA1 (patch-aj) = 0f68f94aa285a4d1ae38cfd2d62b10f96ad325a6
 SHA1 (patch-ak) = c24f82c5440095cb4e55ac665f2b5936116b4e32
-SHA1 (patch-al) = 7fe4d59f45bb865dcfbeef3a1f2d7c4023185eca
-SHA1 (patch-am) = 6c9735b35ddca75df5e0446ee4a46a62ff69fef3
-SHA1 (patch-an) = ec8d8faf329f40e06f865aa790e36f1b6cd81fbb
-SHA1 (patch-ao) = e23fc61440465d1792fbcc51aeeb1077393c87e9
-SHA1 (patch-ap) = 052d155e698fb36b87e4a28a4b1f75f701b7c956
-SHA1 (patch-aq) = 23e551d1bf36e031a629d9d9e817d135886191ab
+SHA1 (patch-al) = df1c2da097eead9444c4cf6a43ea515582258ad9
+SHA1 (patch-am) = d005bf2020b0b88026e53a08d6a35a7b451ef777
+SHA1 (patch-an) = 7d454b745e4a7a303c25e040936c72db92554ad4
+SHA1 (patch-ao) = e19a532f79dd4ad203b9fe19bbde49da7f92a753
+SHA1 (patch-ap) = 860c3989306e5d431520ddf5f676938da8806c87
+SHA1 (patch-aq) = 29db774435c55ccadb7ed492c93eb233df502ca0
 SHA1 (patch-ar) = 0883b75e210d635f7e9f49c9b2b5d3978645953b
 SHA1 (patch-as) = daf5a80d044933c17f8ab556bebc0765af1439e3
-SHA1 (patch-at) = 8e3b746df1369ee3a13fff4ab97eff78c8b53f0e
-SHA1 (patch-au) = 6f2ea2f3fec2756f0f1267a5d68e92b3773e1065
+SHA1 (patch-at) = f6b3fe0bac12489d314e3a1b39bfe67d67b14374
+SHA1 (patch-au) = 90b0a4630b3029b34752972a7e7892b63462a703
diff -r afa5fabc53e8 -r 477c827af950 comms/fidogate/patches/patch-aa
--- a/comms/fidogate/patches/patch-aa   Mon Aug 23 14:50:04 2004 +0000
+++ b/comms/fidogate/patches/patch-aa   Mon Aug 23 15:18:02 2004 +0000
@@ -1,7 +1,7 @@
-$NetBSD: patch-aa,v 1.5 2002/07/06 20:15:52 tv Exp $
+$NetBSD: patch-aa,v 1.6 2004/08/23 15:18:02 tv Exp $
 
---- config.make.orig   Mon Aug 20 01:23:53 2001
-+++ config.make        Sat Jul  6 15:19:41 2002
+--- config.make.orig   2003-04-15 14:45:20.000000000 -0400
++++ config.make
 @@ -56,13 +56,13 @@
  #
  
@@ -23,7 +23,7 @@
  DEFAULT_V_BTBASEDIR   = /var/spool/bt
  DEFAULT_V_INBOUND     = $(DEFAULT_V_BTBASEDIR)/in
  DEFAULT_V_PINBOUND    = $(DEFAULT_V_BTBASEDIR)/pin
-@@ -83,17 +83,17 @@
+@@ -83,8 +83,8 @@ DEFAULT_V_CHARSETMAP = %L/charset.bin
  
  # fixed parameters, DO NOT DELETE ANYTHING!!!
  # INN (Redhat 5.2)
@@ -34,8 +34,11 @@
  # INN 1.7
  #DEFAULT_F_NEWSLIBDIR = /usr/lib/news
  #DEFAULT_F_NEWSSPOOLDIR       = /var/spool/news
- # INN 2.2
--DEFAULT_F_NEWSLIBDIR  = /usr/lib
+@@ -92,11 +92,11 @@ DEFAULT_F_NEWSVARDIR       = /var/lib/news
+ #DEFAULT_F_NEWSLIBDIR = /usr/lib
+ #DEFAULT_F_NEWSSPOOLDIR       = /var/spool/news/articles
+ # INN 2.3.4 on RedHat 9
+-DEFAULT_F_NEWSLIBDIR  = /usr/lib/news/lib
 -DEFAULT_F_NEWSSPOOLDIR        = /var/spool/news/articles
 +DEFAULT_F_NEWSLIBDIR  = @PREFIX@/inn/lib
 +DEFAULT_F_NEWSSPOOLDIR        = /var/news/spool/articles
@@ -46,7 +49,7 @@
  
  # old-style config
  #DEFAULT_F_CONFIG_GATE        = %C/gate.conf
-@@ -146,18 +146,15 @@
+@@ -149,18 +149,15 @@ DEFAULT_A_UUINBOUND      = %U
  
  
  # The perl interpreter used by subst.pl
@@ -70,7 +73,7 @@
  
  # RedHat RPM related dirs
  RPMBASEDIR    = /usr/src/redhat
-@@ -197,20 +194,17 @@
+@@ -200,20 +197,17 @@ GROUP            = news
  # install permissions
  PERM_PROG     = 755
  PERM_DATA     = 644
@@ -93,7 +96,7 @@
  
  INCLUDE               = -I$(TOPDIR) -I$(TOPDIR)/src/include
  
-@@ -239,10 +233,10 @@
+@@ -242,10 +236,10 @@ INSTALL          = install
  # MSDOS, OS2, WIN32
  # EXE         = .exe
  EXE           =
diff -r afa5fabc53e8 -r 477c827af950 comms/fidogate/patches/patch-ac
--- a/comms/fidogate/patches/patch-ac   Mon Aug 23 14:50:04 2004 +0000
+++ b/comms/fidogate/patches/patch-ac   Mon Aug 23 15:18:02 2004 +0000
@@ -1,7 +1,7 @@
-$NetBSD: patch-ac,v 1.3 2001/02/22 03:00:15 tv Exp $
+$NetBSD: patch-ac,v 1.4 2004/08/23 15:18:02 tv Exp $
 
---- config.h.orig      Wed Feb 21 16:59:45 2001
-+++ config.h   Wed Feb 21 17:09:49 2001
+--- config.h.orig      2002-07-15 16:21:55.000000000 -0400
++++ config.h
 @@ -108,7 +108,7 @@
  /***** rfc2ftn configuration ************************************************/
  
@@ -11,12 +11,10 @@
  /** Passthru operation for EchoMail: FIDO->Internet->FIDO **/
  /*
   * Implemented, but requires ftntoss run after rfc2ftn to sort SEEN-BY
-@@ -300,6 +300,25 @@
- # define HAS_SNPRINTF         /* ? */
- # define HAS_HARDLINKS
+@@ -302,6 +302,25 @@
  # undef  HAS_POSIX_REGEX      /* ? */
-+#endif
-+
+ #endif
+ 
 +#ifdef __NetBSD__
 +# define HAS_FCNTL_LOCK
 +# define HAS_GETTIMEOFDAY
@@ -34,6 +32,8 @@
 +# define HAS_SNPRINTF
 +# define HAS_HARDLINKS
 +# define HAS_POSIX_REGEX
- #endif
- 
++#endif
++
  #ifdef ISC                    /* ISC 3.x, GNU gcc, -DISC necessary */
+ # define HAS_FCNTL_LOCK
+ # define HAS_GETTIMEOFDAY
diff -r afa5fabc53e8 -r 477c827af950 comms/fidogate/patches/patch-al
--- a/comms/fidogate/patches/patch-al   Mon Aug 23 14:50:04 2004 +0000
+++ b/comms/fidogate/patches/patch-al   Mon Aug 23 15:18:02 2004 +0000
@@ -1,13 +1,26 @@
-$NetBSD: patch-al,v 1.4 2001/03/19 13:23:36 dmcmahill Exp $
-
-alpha fixes...
+$NetBSD: patch-al,v 1.5 2004/08/23 15:18:02 tv Exp $
 
---- src/common/log.c.orig      Wed Oct 18 17:53:57 2000
-+++ src/common/log.c   Mon Mar 19 07:37:02 2001
-@@ -138,5 +138,5 @@
+--- src/common/log.c.orig      2003-02-16 10:38:56.000000000 -0500
++++ src/common/log.c
+@@ -137,7 +137,7 @@ void log(const char *fmt, ...)
+       if(fp)
        {
            fprintf(fp, "%s %s ",
 -                  date_buf(buf, sizeof(buf), DATE_LOG, (long *)0), logprog);
 +                  date_buf(buf, sizeof(buf), DATE_LOG, (time_t *)0), logprog);
            vfprintf(fp, *fmt == '$' ? fmt + 1 : fmt, args);
            if (*fmt == '$')
+               fprintf(fp, " (errno=%d: %s)", errno, strerror(errno));
+@@ -276,12 +276,5 @@ void log_file(char *name)
+  */
+ void log_program(char *name)
+ {
+-    char *p;
+-    
+     BUF_COPY(logprog, name);
+-
+-    if( (p = getenv("LOGFILE")) )
+-       log_file(p);
+-    if( (p = getenv("FIDOGATE_LOGFILE")) )
+-       log_file(p);
+ }
diff -r afa5fabc53e8 -r 477c827af950 comms/fidogate/patches/patch-am
--- a/comms/fidogate/patches/patch-am   Mon Aug 23 14:50:04 2004 +0000
+++ b/comms/fidogate/patches/patch-am   Mon Aug 23 15:18:02 2004 +0000
@@ -1,17 +1,18 @@
-$NetBSD: patch-am,v 1.4 2001/03/19 13:23:36 dmcmahill Exp $
-
-alpha fixes...
+$NetBSD: patch-am,v 1.5 2004/08/23 15:18:02 tv Exp $
 
---- src/common/tick.c.orig     Fri Jan 28 17:01:11 2000
-+++ src/common/tick.c  Mon Mar 19 07:47:47 2001
-@@ -121,5 +121,5 @@
+--- src/common/tick.c.orig     2003-02-16 10:38:58.000000000 -0500
++++ src/common/tick.c
+@@ -120,7 +120,7 @@ int tick_put(Tick *tic, char *name)
+     fprintf(fp, "CRC %08lX\r\n", tic->crc);
      fprintf(fp, "Created %s\r\n", tic->created);
      fprintf(fp, "Size %lu\r\n", tic->size);
 -    fprintf(fp, "Date %ld\r\n", tic->date);
 +    fprintf(fp, "Date %ld\r\n", (long) tic->date);
      for(pl=tic->path.first; pl; pl=pl->next)
        fprintf(fp, "Path %s\r\n", pl->line);
-@@ -279,6 +279,6 @@
+     for(p=tic->seenby.first; p; p=p->next)
+@@ -278,8 +278,8 @@ void tick_debug(Tick *tic, int lvl)
+     for(p=tic->seenby.first; p; p=p->next)
        debug(lvl, "Seenby   : %s", znfp1(&p->node));
      debug(lvl, "Pw       : %s", tic->pw);
 -    debug(lvl, "Release  : %ld", tic->release);
@@ -20,7 +21,9 @@
 +    debug(lvl, "Date     : %ld", (long) tic->date);
      for(pl=tic->app.first; pl; pl=pl->next)
        debug(lvl, "App      : %s", pl->line);
-@@ -368,5 +368,5 @@
+ }
+@@ -367,6 +367,6 @@ void tick_add_path(Tick *tic)
+ 
      now = time(NULL);
      tl_appendf(&tic->path, "%s %ld %s",
 -             znf1(cf_addr()), now, date(DATE_TICK_PATH, &now));
diff -r afa5fabc53e8 -r 477c827af950 comms/fidogate/patches/patch-an
--- a/comms/fidogate/patches/patch-an   Mon Aug 23 14:50:04 2004 +0000
+++ b/comms/fidogate/patches/patch-an   Mon Aug 23 15:18:02 2004 +0000
@@ -1,20 +1,22 @@
-$NetBSD: patch-an,v 1.4 2001/03/19 13:23:36 dmcmahill Exp $
-
-alpha fixes...
+$NetBSD: patch-an,v 1.5 2004/08/23 15:18:02 tv Exp $
 
---- src/tick/ftnhatch.c.orig   Fri Nov 17 16:18:08 2000
-+++ src/tick/ftnhatch.c        Mon Mar 19 07:50:57 2001
-@@ -100,5 +100,5 @@
+--- src/tick/ftnhatch.c.orig   2003-02-16 10:39:02.000000000 -0500
++++ src/tick/ftnhatch.c
+@@ -99,7 +99,7 @@ int hatch(char *area, char *file, char *
+     file_crc  = crc32_file(file_name);
      
      debug(4, "file: name=%s size=%ld time=%ld crc=%08lx",
 -        file_name, file_size, file_time, file_crc);
 +        file_name, file_size, (long) file_time, file_crc);
  
      /*
-@@ -119,5 +119,5 @@
-     tic.size    = file_size;
+      * Build Tick struct
+@@ -119,7 +119,7 @@ int hatch(char *area, char *file, char *
+     tic.created  = CREATOR;
+     tic.size     = file_size;
      tl_appendf(&tic.path, "%s %ld %s",
 -             znf1(cf_addr()), now, date(NULL, &now) );
 +             znf1(cf_addr()), (long) now, date(NULL, &now) );
      lon_add(&tic.seenby, cf_addr());
      lon_join(&tic.seenby, &bbs->nodes);
+     /* tic.pw set by hatch_one() */
diff -r afa5fabc53e8 -r 477c827af950 comms/fidogate/patches/patch-ao
--- a/comms/fidogate/patches/patch-ao   Mon Aug 23 14:50:04 2004 +0000
+++ b/comms/fidogate/patches/patch-ao   Mon Aug 23 15:18:02 2004 +0000
@@ -1,34 +1,40 @@
-$NetBSD: patch-ao,v 1.1 2001/03/19 13:23:36 dmcmahill Exp $
-
-alpha fixes...
+$NetBSD: patch-ao,v 1.2 2004/08/23 15:18:02 tv Exp $
 
---- src/toss/ftnexpire.c.orig  Fri Nov 17 16:18:08 2000
-+++ src/toss/ftnexpire.c       Mon Mar 19 08:12:29 2001
-@@ -113,5 +113,5 @@
+--- src/toss/ftnexpire.c.orig  2003-02-16 10:39:02.000000000 -0500
++++ src/toss/ftnexpire.c
+@@ -112,7 +112,7 @@ int do_expire(void)
+     if(exp_sec < 0)
        exp_sec = 0;
      debug(4, "expire: now=%ld max=%ld, expire < %ld",
 -        now_sec, max_sec, exp_sec                   );
 +        (long) now_sec, (long) max_sec, (long) exp_sec                   );
  
      /* Open old history for reading */
-@@ -223,5 +223,5 @@
+     if( (hi_o = fopen(history, R_MODE)) == NULL ) 
+@@ -222,7 +222,7 @@ int do_line(FILE *hi_n, char *line)
+     t = atol(p);
      expired = t < exp_sec;
      debug(7, "msgid=%s  time=%ld  expired=%s",
 -        msgid, t, expired ? "YES" : "NO"     );
 +        msgid,(long) t, expired ? "YES" : "NO"     );