[pkgsrc/trunk]: pkgsrc/lang/php php: Remove LIBTOOL_OVERRIDE=YES.

[jperkin <jperkin%pkgsrc.org@localhost>]

details:   https://anonhg.NetBSD.org/pkgsrc/rev/571f49c5d603
branches:  trunk
changeset: 375273:571f49c5d603
user:      jperkin <jperkin%pkgsrc.org@localhost>
date:      Wed Feb 07 16:14:36 2018 +0000

description:
php: Remove LIBTOOL_OVERRIDE=YES.

This was added 8 years ago intending to ensure pkgsrc libtool was used, except
it actually did the opposite.  By default we will try to replace any script
named "libtool" up to the override depth.  Setting LIBTOOL_OVERRIDE changes
the behaviour to instead override the list of filenames specified by the
LIBTOOL_OVERRIDE variable.  Thus we were trying to replace any file named
"YES" instead of "libtool".

Noticed by SmartOS/clang builds of php-intl which were using the supplied
broken libtool script instead of the correct pkgsrc one.

diffstat:

 lang/php/ext.mk |  3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)

diffs (17 lines):

diff -r e0661b633d59 -r 571f49c5d603 lang/php/ext.mk
--- a/lang/php/ext.mk   Wed Feb 07 16:12:17 2018 +0000
+++ b/lang/php/ext.mk   Wed Feb 07 16:14:36 2018 +0000
@@ -1,4 +1,4 @@
-# $NetBSD: ext.mk,v 1.44 2016/12/10 07:08:39 taca Exp $
+# $NetBSD: ext.mk,v 1.45 2018/02/07 16:14:36 jperkin Exp $
 #
 # PHP extension package framework, for both PECL and bundled PHP extensions.
 #
@@ -72,7 +72,6 @@
 
 USE_CONFIG_WRAPPER=    YES
 USE_LIBTOOL=           YES
-LIBTOOL_OVERRIDE=      YES
 USE_TOOLS+=            automake
 
 # Ensure we export symbols in the linked shared object.