Subject: Re: pkgsrc Linux 2.6.12-10-amd64-xeon/x86_64 bulk build results 20060425.2241
To: Chris Pinnock <cjep@NetBSD.org>
From: Min Sik Kim <minskim@NetBSD.org>
List: pkgsrc-bulk
Date: 05/02/2006 09:03:38
--Apple-Mail-2-774894327
Content-Transfer-Encoding: 7bit
Content-Type: text/plain;
	charset=US-ASCII;
	delsp=yes;
	format=flowed


On May 2, 2006, at 2:15 AM, joerg@britannica.bec.de wrote:

> On Tue, May 02, 2006 at 09:24:05AM +0000, Chris Pinnock wrote:
>> On Tue, May 02, 2006 at 10:54:01AM +0200, joerg@britannica.bec.de  
>> wrote:
>>> On Mon, May 01, 2006 at 01:24:56PM -0700, Min Sik Kim wrote:
>>>> devel/bison                902     cjep@NetBSD.org
>>>
>>> I vote for --disable-nls.
>>
>> Sorry - completely missed the discussion behind this one. If someone
>> can fix the problem quickly, go for it.
>
> Sorry, issue was that on Linux the translated messages are not  
> recorded
> in the PLIST. The first option is to depend on gettext, but I'm not  
> sure
> if that can introduce a cyclic dependency on some platforms. The other
> option is to completely disable NLS.

devel/bison already has USETOOLS+=msgfmt, which means it is supposed  
to install .mo files.  The only reason that they are not installed on  
NetBSD is that configure searches for a function unavailable in  
libintl.  Since that function (nl_expand_alias) is not used by bison  
anyway, we can simply bypass the test.

Chris, is it okay to apply the attached patch to re-enable translated  
messages?

Regards,
Min


--Apple-Mail-2-774894327
Content-Transfer-Encoding: 7bit
Content-Type: application/octet-stream;
	x-unix-mode=0644;
	name="bison.diff"
Content-Disposition: attachment;
	filename=bison.diff

Index: Makefile
===================================================================
RCS file: /cvsroot/pkgsrc/devel/bison/Makefile,v
retrieving revision 1.58
diff -u -r1.58 Makefile
--- Makefile	13 Apr 2006 18:23:31 -0000	1.58
+++ Makefile	2 May 2006 15:59:32 -0000
@@ -1,6 +1,7 @@
 # $NetBSD: Makefile,v 1.58 2006/04/13 18:23:31 jlam Exp $
 
 DISTNAME=		bison-2.1
+PKGREVISION=		1
 CATEGORIES=		devel
 MASTER_SITES=		${MASTER_SITE_GNU:=bison/}
 EXTRACT_SUFX=		.tar.bz2
@@ -16,6 +17,9 @@
 USE_TOOLS+=		gm4:run msgfmt
 INFO_FILES=		# PLIST
 
+CONFIGURE_ENV+=		gt_cv_func_gnugettext1_libintl=yes
+
 TEST_TARGET=		check
 
+.include "../../devel/gettext-lib/buildlink3.mk"
 .include "../../mk/bsd.pkg.mk"
Index: PLIST
===================================================================
RCS file: /cvsroot/pkgsrc/devel/bison/PLIST,v
retrieving revision 1.13
diff -u -r1.13 PLIST
--- PLIST	30 Mar 2006 03:44:42 -0000	1.13
+++ PLIST	2 May 2006 15:59:32 -0000
@@ -11,5 +11,47 @@
 share/bison/lalr1.cc
 share/bison/m4sugar/m4sugar.m4
 share/bison/yacc.c
+share/locale/da/LC_MESSAGES/bison-runtime.mo
+share/locale/da/LC_MESSAGES/bison.mo
+share/locale/de/LC_MESSAGES/bison-runtime.mo
+share/locale/de/LC_MESSAGES/bison.mo
+share/locale/es/LC_MESSAGES/bison-runtime.mo
+share/locale/es/LC_MESSAGES/bison.mo
+share/locale/et/LC_MESSAGES/bison-runtime.mo
+share/locale/et/LC_MESSAGES/bison.mo
+share/locale/fr/LC_MESSAGES/bison-runtime.mo
+share/locale/fr/LC_MESSAGES/bison.mo
+share/locale/ga/LC_MESSAGES/bison-runtime.mo
+share/locale/ga/LC_MESSAGES/bison.mo
+share/locale/hr/LC_MESSAGES/bison-runtime.mo
+share/locale/hr/LC_MESSAGES/bison.mo
+share/locale/id/LC_MESSAGES/bison-runtime.mo
+share/locale/id/LC_MESSAGES/bison.mo
+share/locale/it/LC_MESSAGES/bison-runtime.mo
+share/locale/it/LC_MESSAGES/bison.mo
+share/locale/ja/LC_MESSAGES/bison-runtime.mo
+share/locale/ja/LC_MESSAGES/bison.mo
+share/locale/ms/LC_MESSAGES/bison-runtime.mo
+share/locale/ms/LC_MESSAGES/bison.mo
+share/locale/nb/LC_MESSAGES/bison-runtime.mo
+share/locale/nb/LC_MESSAGES/bison.mo
+share/locale/nl/LC_MESSAGES/bison-runtime.mo
+share/locale/nl/LC_MESSAGES/bison.mo
+share/locale/pl/LC_MESSAGES/bison-runtime.mo
+share/locale/pl/LC_MESSAGES/bison.mo
+share/locale/pt_BR/LC_MESSAGES/bison-runtime.mo
+share/locale/pt_BR/LC_MESSAGES/bison.mo
+share/locale/ro/LC_MESSAGES/bison-runtime.mo
+share/locale/ro/LC_MESSAGES/bison.mo
+share/locale/ru/LC_MESSAGES/bison-runtime.mo
+share/locale/ru/LC_MESSAGES/bison.mo
+share/locale/rw/LC_MESSAGES/bison-runtime.mo
+share/locale/rw/LC_MESSAGES/bison.mo
+share/locale/sv/LC_MESSAGES/bison-runtime.mo
+share/locale/sv/LC_MESSAGES/bison.mo
+share/locale/tr/LC_MESSAGES/bison-runtime.mo
+share/locale/tr/LC_MESSAGES/bison.mo
+share/locale/vi/LC_MESSAGES/bison-runtime.mo
+share/locale/vi/LC_MESSAGES/bison.mo
 @dirrm share/bison/m4sugar
 @dirrm share/bison

--Apple-Mail-2-774894327--