Re: pkgsrc NetBSD 1.6.2/i386 bulk build results 2005-05-21

[Krister Walfridsson <cato%df.lth.se@localhost>]

On Sat, 21 May 2005, Thomas Klausner wrote:
> On Sat, May 21, 2005 at 04:08:06PM +0200, Krister Walfridsson wrote:
> > pkgsrc bulk build results
> > NetBSD 1.6.2/i386
>
> Lots of breakage because gtar was linked against libiconv without
> having a dependency.

This has been the case since the change

  Module Name:    pkgsrc
  Committed By:   epg
  Date:           Tue Apr 19 14:55:30 UTC 2005

  Modified Files:
          pkgsrc/devel/gettext-lib: buildlink3.mk builtin.mk

  Log Message:
  Include ../../converters/libiconv/buildlink3.mk in buildlink3.mk,
  and let it worry about whether libiconv is built-in or not.  Remove
  all references to libiconv from builtin.mk.

  The logic in builtin.mk was broken and unnecessary, leading to a
  build failure on at least some Linux systems (such as Debian woody
  without any gettext packages installed).

that pulls in converters/libiconv/buildlink3.mk regardless of if
it is needed or not (we have not seen it fail in he bulk builds
because it was not used during the build before Johnny's recent
changes).

I'm fine with just adding converters/libiconv/buildlink3.mk as
an explicit dependency to archivers/gtar-base too.  Or should
we do something magic to prevent its usage unless it is really
needed?  (I do not have the knowledge to the latter, so someone
else need to do that...)

   /Krister