Subject: Re: use of ls in mk/bulk/post-build
To: Jan Schaumann <jschauma@netmeister.org>
From: Todd Vierling <tv@duh.org>
List: pkgsrc-bulk
Date: 04/21/2005 16:14:31
On Mon, 11 Apr 2005, Jan Schaumann wrote:

> In rev 1.49 of  pkgsrc/mk/bulk/post-build, you committed

Sorry I haven't gotten back to you on this yet....

> -chdir($USR_PKGSRC);
> -system("find . -name $BROKENFILE -print -o -name $BROKENWRKLOG -print | $GTAR -T - -plcf - | (cd $FTP; $GTAR -plxf -)");
> +chdir($vars{USR_PKGSRC});
> +my_system("/bin/ls -1 $vars{BROKENFILE} $vars{BROKENWRKLOG} */*/$vars{BROKENFILE} */*/$vars{BROKENWRKLOG} 2>/dev/null | $vars{GTAR} -T - -plcf - | (cd $vars{FTP}; $vars{GTAR} -plxf -)");
>
> On some systems, this now leads to too many arguments to ls(1),
> subsequently producing an empty bulk-log.  What was wrong with using
> find(1)?

NFS slowness, for a nfs-mounted pkgsrc.

Hm.  This is ugly.  I suppose it can go back to find, but I may try to find
a new way to do this in the future.

-- 
-- Todd Vierling <tv@duh.org> <tv@pobox.com> <todd@vierling.name>