pkg/59472: textproc/ruby-nokogiri fails to install on Darwin

[triaxx%netbsd.org@localhost]

>Number:         59472
>Category:       pkg
>Synopsis:       textproc/ruby-nokogiri fails to install on Darwin
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Thu Jun 19 05:10:00 +0000 2025
>Originator:     Frédéric Fauberteau
>Release:        NetBSD 10.1
>Organization:
>Environment:
System: Darwin arbiter 24.5.0 Darwin Kernel Version 24.5.0: Tue Apr 22 19:54:26 PDT 2025; root:xnu-11417.121.6~2/RELEASE_ARM64_T8112 arm64
Architecture: arm
Machine: arm64
>Description:
When trying to install textproc/ruby-nokogiri on Darwin/arm64, the following error occurs. 

=> Bootstrap dependency digest>=20211023: found digest-20220214
===> Invoking ``install'' after barrier for ruby34-nokogiri-1.18.8
===> Checking for vulnerabilities in ruby34-nokogiri-1.18.8
===> Installing for ruby34-nokogiri-1.18.8
=> Generating pre-install file lists
=> Installing gem into installation root
Building native extensions. This could take a while...
ERROR:  Error installing /Users/triaxx/pkgsrc/textproc/ruby-nokogiri/work/nokogiri-1.18.8/nokogiri-1.18.8.gem:
	ERROR: Failed to build gem native extension.

    current directory: /Users/triaxx/pkgsrc/textproc/ruby-nokogiri/work/.inst/Users/triaxx/pkg/lib/ruby/gems/3.4.0/gems/nokogiri-1.18.8/ext/nokogiri
/Users/triaxx/pkg/bin/ruby34 extconf.rb
checking for whether -O2 -I/Users/triaxx/pkg/include/libxml2 -I/Users/triaxx/pkg/include -D_REENTRANT is accepted as CFLAGS... no
checking for whether -I/Users/triaxx/pkg/include/libxml2 -I/Users/triaxx/pkg/include -D_REENTRANT is accepted as CPPFLAGS... no
checking for whether -L/Users/triaxx/pkg/lib is accepted as LDFLAGS... yes
checking for whether -std=c99 is accepted as CFLAGS... no
checking for whether -Wno-declaration-after-statement is accepted as CFLAGS... no
checking for whether -O2 is accepted as CFLAGS... no
checking for whether -g is accepted as CFLAGS... no
checking for whether -Winline is accepted as CFLAGS... no
checking for whether -Wmissing-noreturn is accepted as CFLAGS... no
checking for whether -Wconversion is accepted as CFLAGS... no
checking for whether -Wno-error=unused-command-line-argument-hard-error-in-future is accepted as CFLAGS... no
checking for whether -Wno-unknown-warning-option is accepted as CFLAGS... no
checking for whether -I/Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/usr/include/libxml2 is accepted as CPPFLAGS... no
Building nokogiri using system libraries.
checking for gzdopen() in -lz... yes
checking for xmlParseDoc() in -lxml2... yes
checking for xsltParseStylesheetDoc() in -lxslt... yes
checking for exsltFuncRegister() in -lexslt... yes
WARNING: libxml2 version 2.12.0 or later is highly recommended, but proceeding anyway.
Using mini_portile version 2.8.9
---------- IMPORTANT NOTICE ----------
Building Nokogiri with a packaged version of libgumbo-1.0.0-nokogiri.
Configuration options: --enable-shared --disable-static
Copying gumbo-parser files into tmp/arm64-apple-darwin24/ports/libgumbo/1.0.0-nokogiri/gumbo-parser...
Running 'compile' for libgumbo 1.0.0-nokogiri... OK
Activating libgumbo 1.0.0-nokogiri (from ports/arm64-darwin24/libgumbo/1.0.0-nokogiri)...
checking for whether -I/Users/triaxx/pkgsrc/textproc/ruby-nokogiri/work/.inst/Users/triaxx/pkg/lib/ruby/gems/3.4.0/gems/nokogiri-1.18.8/ext/nokogiri/ports/arm64-darwin24/libgumbo/1.0.0-nokogiri/include is accepted as CPPFLAGS... no
checking for gumbo_parse_with_options() in nokogiri_gumbo.h... yes
checking for xmlCtxtSetOptions()... yes
checking for xmlCtxtGetOptions()... yes
checking for xmlSwitchEncodingName()... yes
checking for rb_category_warning()... yes
checking for whether -DNOKOGIRI_OTHER_LIBRARY_VERSIONS="\"libgumbo:1.0.0-nokogiri\"" is accepted as CPPFLAGS... yes
creating Makefile

current directory: /Users/triaxx/pkgsrc/textproc/ruby-nokogiri/work/.inst/Users/triaxx/pkg/lib/ruby/gems/3.4.0/gems/nokogiri-1.18.8/ext/nokogiri
make DESTDIR\= sitearchdir\=./.gem.20250619-51613-raykb4 sitelibdir\=./.gem.20250619-51613-raykb4 clean

current directory: /Users/triaxx/pkgsrc/textproc/ruby-nokogiri/work/.inst/Users/triaxx/pkg/lib/ruby/gems/3.4.0/gems/nokogiri-1.18.8/ext/nokogiri
make DESTDIR\= sitearchdir\=./.gem.20250619-51613-raykb4 sitelibdir\=./.gem.20250619-51613-raykb4
compiling gumbo.c
gumbo.c:32:10: fatal error: 'nokogiri_gumbo.h' file not found
   32 | #include "nokogiri_gumbo.h"
      |          ^~~~~~~~~~~~~~~~~~
1 error generated.
*** Error code 1

Stop.
make: stopped making "all" in /Users/triaxx/pkgsrc/textproc/ruby-nokogiri/work/.inst/Users/triaxx/pkg/lib/ruby/gems/3.4.0/gems/nokogiri-1.18.8/ext/nokogiri

make failed, exit code 1

Gem files will remain installed in /Users/triaxx/pkgsrc/textproc/ruby-nokogiri/work/.inst/Users/triaxx/pkg/lib/ruby/gems/3.4.0/gems/nokogiri-1.18.8 for inspection.
Results logged to /Users/triaxx/pkgsrc/textproc/ruby-nokogiri/work/.inst/Users/triaxx/pkg/lib/ruby/gems/3.4.0/extensions/arm64-darwin-24/3.4.0/nokogiri-1.18.8/gem_make.out
*** Error code 1

Stop.
bmake[1]: stopped making "install" in /Users/triaxx/pkgsrc/textproc/ruby-nokogiri
*** Error code 1

Stop.
bmake: stopped making "install" in /Users/triaxx/pkgsrc/textproc/ruby-nokogiri
>How-To-Repeat:
cd ~/pkgsrc/textproc/ruby-nokogiri && ~/pkg/bin/bmake install
>Fix:
I am not sure it is the best workaround but the following patch fixes the installation error.

Index: Makefile
===================================================================
RCS file: /cvsroot/pkgsrc/textproc/ruby-nokogiri/Makefile,v
retrieving revision 1.103
diff -u -r1.103 Makefile
--- Makefile	29 Apr 2025 11:04:47 -0000	1.103
+++ Makefile	19 Jun 2025 04:51:20 -0000
@@ -23,6 +23,12 @@
 # XXX: work around bug in bootstrap-mk-files, remove when fixed
 MAKE_ENV.SunOS+=	ARFLAGS=rcv
 
+.include "../../mk/bsd.prefs.mk"
+
+.if ${OPSYS} == "Darwin"
+RUBY_EXTCONF_ARGS+=     --gumbo-dev
+.endif
+
 .include "../../devel/ruby-pkg-config/tool.mk"
 .include "../../textproc/libxml2/buildlink3.mk"
 .include "../../textproc/libxslt/buildlink3.mk"
Index: PLIST.Darwin
===================================================================
RCS file: PLIST.Darwin
diff -N PLIST.Darwin
--- /dev/null	1 Jan 1970 00:00:00 -0000
+++ PLIST.Darwin	19 Jun 2025 04:51:20 -0000
@@ -0,0 +1,2 @@
+@comment $NetBSD$
+${GEM_HOME}/build_info/${GEM_NAME}.info