Re: pkg/58826: graphics/blender: ld: cannot find -lminizip: No such file or directory

[Rob Whitlock <rwhitlock22%gmail.com@localhost>]

> On Nov 12, 2024, at 11:18 PM, Ryo ONODERA <ryo%tetera.org@localhost> wrote:
> 
> Hi,
> 
> "Thomas Klausner via gnats" <gnats-admin%NetBSD.org@localhost> writes:
> 
>> The following reply was made to PR pkg/58826; it has been noted by GNATS.
>> 
>> From: Thomas Klausner <wiz%NetBSD.org@localhost>
>> To: NetBSD bugtracking <gnats-bugs%NetBSD.org@localhost>
>> Cc: 
>> Subject: Re: pkg/58826: graphics/blender: ld: cannot find -lminizip: No such
>> file or directory
>> Date: Mon, 11 Nov 2024 17:01:50 +0100
>> 
>> On Mon, Nov 11, 2024 at 02:50:00PM +0000, rwhitlock22%gmail.com@localhost wrote:
>>> "make install" fails with error "ld: cannot find -lminizip: No such
>>> file or directory". Full output below. Note that this doesn't seem to
>>> show up in the bulk builds, so I suspect the minizip dependency isn't
>>> being handled correctly. There are also references to minizipng (or
>>> minizip-ng) so the error might also be a result of confusing those two
>>> packages.
>> 
>> Solution:
>> pkg_delete minizip
>> 
>> Sadly I didn't find a way to disable its detection in blender.
>> minizip-ng is installed and buildlink3ed via opencolorio.
>> You could report this upstream, I don't think we can do much in pkgsrc.
>>  Thomas
> 
> graphics/blender-lts has a workaround for minizip/minizip-ng.
> I will add the workaround to graphics/blender tonight.
> 
> # graphics/blender does not work for my laptop anymore.
> # It requires hardware GPU support (llvmpipe is unacceptable).
> 
> -- 
> Ryo ONODERA // ryo%tetera.org@localhost
> PGP fingerprint = 82A2 DC91 76E0 A10A 8ABB  FD1B F404 27FA C7D1 15F3

Here's a patch that does so. Blender builds and runs with this patch.

I didn't include the "Do not find libminizip.so when archivers/minizip is installed" that was in the graphics/blender-lts version of this file because I didn't see that problem. In fact, my problem was the opposite, which was that libminizip.so was not found at all, not that it was incorrectly being found.

$NetBSD$

* Fix build failure '-lminizip not found'.

--- build_files/cmake/Modules/FindOpenColorIO.cmake.orig	2024-06-05 11:47:55.000000000 +0000
+++ build_files/cmake/Modules/FindOpenColorIO.cmake
@@ -29,7 +29,7 @@ set(_opencolorio_FIND_COMPONENTS
   yaml-cpp
   expat
   pystring
-  minizip
+  minizip-ng
 )
 
 set(_opencolorio_SEARCH_DIRS