pkgsrc-Bugs archive
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]
Re: pkg/58835: mail/thunderbird102 build failure - "rust panic"
The following reply was made to PR pkg/58835; it has been noted by GNATS.
From: Thomas Klausner <wiz%gatalith.at@localhost>
To: NetBSD bugtracking <gnats-bugs%NetBSD.org@localhost>
Cc:
Subject: Re: pkg/58835: mail/thunderbird102 build failure - "rust panic"
Date: Thu, 21 Nov 2024 12:52:49 +0100
--bojaKrdHSQw321kl
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
On Wed, Nov 20, 2024 at 10:10:01AM +0000, Hauke Fath wrote:
> >Number: 58835
> >Category: pkg
> >Synopsis: mail/thunderbird102 build failure - "rust panic"
> >Confidential: no
> >Severity: serious
> >Priority: medium
> >Responsible: pkg-manager
> >State: open
> >Class: sw-bug
> >Submitter-Id: net
> >Arrival-Date: Wed Nov 20 10:10:00 +0000 2024
> >Originator: Hauke Fath
> >Release: NetBSD 10.0_STABLE
> >Organization:
> Technische Universitaet Darmstadt
> >Environment:
> =09
> =09
> System: NetBSD Gstoder 10.0_STABLE NetBSD 10.0_STABLE (THRIP-$Revision$) =
#3: Tue Oct 15 20:40:31 CEST 2024 hf4kh@Hochstuhl:/var/obj/netbsd-builds/10=
/amd64/sys/arch/amd64/compile/THRIP amd64
> Architecture: x86_64
> Machine: amd64
> >Description:
>=20
> mail/thunderbird102 fails to build, with the following output:
>=20
> % env MAKE_JOBS=3D1 RUST_BACKTRACE=3Dfull make
>=20
> [...]
>=20
> gmake[3]: Leaving directory '/var/obj/pkgsrc/mail/thunderbird102/work/bui=
ld/xpcom/xpidl'
> BUILDTASK {"argv": ["/var/obj/pkgsrc/mail/thunderbird102/work/thunderbird=
-102.15.1/python/mozbuild/mozbuild/action/file_generate.py", "/var/obj/pkgs=
rc/mail/thunderbird102/work/thunderbird-102.15.1/python/mozbuild/mozbuild/a=
ction/preprocessor.py", "generate", "build/application.ini", "build/.deps/a=
pplication.ini.pp", "build/.deps/application.ini.stub", "/var/obj/pkgsrc/ma=
il/thunderbird102/work/thunderbird-102.15.1/build/application.ini.in", "-DG=
RE_MILESTONE=3D102.15.1", "-DMAR_CHANNEL_ID=3D", "-DMOZ_APPUPDATE_HOST=3Dau=
s.thunderbird.net", "-DMOZ_APP_BASENAME=3DThunderbird", "-DMOZ_APP_DISPLAYN=
AME=3DThunderbird Daily", "-DMOZ_APP_ID=3D{3550f703-e582-4d05-9a08-453d09bd=
fdc6}", "-DMOZ_APP_REMOTINGNAME=3Dthunderbird102-default", "-DMOZ_APP_VENDO=
R=3D", "-DMOZ_APP_VERSION=3D102.15.1", "-DMOZ_CRASHREPORTER_URL=3Dhttps://c=
rash-reports.mozilla.com", "-DMOZ_PROFILE_MIGRATOR=3D1", "-DTOPOBJDIR=3D/va=
r/obj/pkgsrc/mail/thunderbird102/work/build"], "start": 1732018310.5902858,=
"end": 1732018310.594789, "context": nu!
> ll}
>=20
> thread 'main' panicked at src/bindgen/config.rs:1125:34:
> called `Result::unwrap()` on an `Err` value: "Couldn't parse config file:=
TOML parse error at line 296, column 1\n |\n296 | \"Keyframe\" =3D \"Ke=
yframe\"\n | ^\nduplicate key `Keyframe` in table `export.rename`\n."
> stack backtrace:
> 0: 0x10bbe9f9 - <std::sys_common::backtrace::_print::DisplayBa=
cktrace as core::fmt::Display>::fmt::h166e1724504b217f
> 1: 0x10bf12ab - core::fmt::write::hb2b2db83f5937d87
> 2: 0x10bd8f39 - std::io::Write::write_fmt::hb4d4341c18b5a812
> 3: 0x10bbe7e8 - std::sys_common::backtrace::print::hac78e95374=
03e26d
> 4: 0x10bd663a - std::panicking::default_hook::{{closure}}::hfe=
0ad5bec784a197
> 5: 0x10bd6393 - std::panicking::default_hook::he263d1b4d256e8ac
> 6: 0x10bd6c29 - std::panicking::rust_panic_with_hook::h9f8e14c=
6161774f5
> 7: 0x10bbedc4 - std::panicking::begin_panic_handler::{{closure=
}}::he0833bc09348f0fe
> 8: 0x10bbec09 - std::sys_common::backtrace::__rust_end_short_b=
acktrace::h69103541b546afc7
> 9: 0x10bd67c7 - rust_begin_unwind
> 10: 0x10832563 - core::panicking::panic_fmt::h9ed76b0c66cc4179
> 11: 0x10832aa6 - core::result::unwrap_failed::hd56473036dff47cd
> 12: 0x10a14fc1 - cbindgen::main::h846b4e8f41f01fb6
> 13: 0x109a7453 - std::sys_common::backtrace::__rust_begin_short=
_backtrace::h815ce684332cd4ba
> 14: 0x109e10f9 - std::rt::lang_start::{{closure}}::hf716a53a779=
60bcd
> 15: 0x10bd66b7 - std::panicking::try::h8499e23d6135edb6
> 16: 0x10bd0f5d - std::rt::lang_start_internal::h09913a81d70b778a
> 17: 0x10a18005 - main
> 18: 0x108214bd - ___start
>=20
> BUILDTASK {"argv": ["/var/obj/pkgsrc/mail/thunderbird102/work/thunderbird=
-102.15.1/python/mozbuild/mozbuild/action/file_generate.py", "/var/obj/pkgs=
rc/mail/thunderbird102/work/thunderbird-102.15.1/build/RunCbindgen.py", "ge=
nerate", "layout/style/ServoStyleConsts.h", "layout/style/.deps/ServoStyleC=
onsts.h.pp", "layout/style/.deps/ServoStyleConsts.h.stub", "config/cbindgen=
-metadata.json", "/var/obj/pkgsrc/mail/thunderbird102/work/thunderbird-102.=
15.1/servo/ports/geckolib", "/var/obj/pkgsrc/mail/thunderbird102/work/thund=
erbird-102.15.1/servo/components/style"], "start": 1732018310.560984, "end"=
: 1732018310.598336, "context": null}
> ./application.ini.h.stub
> /var/obj/pkgsrc/mail/thunderbird102/work/build/_virtualenvs/build/bin/pyt=
hon -m mozbuild.action.file_generate /var/obj/pkgsrc/mail/thunderbird102/wo=
rk/thunderbird-102.15.1/build/appini_header.py main build/application.ini.h=
build/.deps/application.ini.h.pp build/.deps/application.ini.h.stub build/=
application.ini
> gmake[2]: *** [backend.mk:540: layout/style/.deps/ServoStyleConsts.h.stub=
] Error 101
>=20
>=20
> =09
> >How-To-Repeat:
>=20
> Attempt to build mail/thunderbird102.
>=20
> Coincidentally, "rust panic" nicely describes my feelings.
>=20
> =09
> >Fix:
> =09
>=20
> Yes, please.
Try applying the patch that was necessary for firefox102, if you're
interested in working on this.
Thomas
--bojaKrdHSQw321kl
Content-Type: message/rfc822
Content-Disposition: inline
Return-Path: <bounces-pkgsrc-changes-owner-wiz=netbsd.org%NetBSD.org@localhost>
Delivered-To: wiz%gatalith.at@localhost
Received: from gatalith.at
by gatalith.at with LMTP
id t0pnO6+a6mbxTAAA4iLUCg
(envelope-from <bounces-pkgsrc-changes-owner-wiz=netbsd.org%NetBSD.org@localhost>)
for <wiz%gatalith.at@localhost>; Wed, 18 Sep 2024 11:17:35 +0200
Received: from mail.netbsd.org (mail.netbsd.org [199.233.217.200])
by gatalith.at (Postfix) with ESMTPS id 3904C390A1E
for <wiz%gatalith.at@localhost>; Wed, 18 Sep 2024 11:17:35 +0200 (CEST)
Received: by mail.netbsd.org (Postfix)
id A9C77855DF; Wed, 18 Sep 2024 09:17:32 +0000 (UTC)
Delivered-To: wiz%netbsd.org@localhost
Received: by mail.netbsd.org (Postfix, from userid 605)
id 19F4F855C2; Wed, 18 Sep 2024 09:17:32 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netbsd.org;
s=20240131; t=1726651052;
bh=zjJ6o/Q8SA/uxcO9rmfHNoY15tNCyzmqpegqbunv2wo=;
h=Date:From:Subject:To:Reply-To:List-Id:List-Unsubscribe;
b=p3BOyJ/XLAHUPsJAgRlThcw6+EfwhgMhIhBY5CpqqpIoEO8EDhuVB4vx+JU0vwy8p
nqEBqkdymDcFYPHDDwA+ookzKYKx2or/tbXHCSLeoxkTZEwvLDhcbo8DJycd3cZeJv
NVNY3RpV+WVrUuHWJuCODviYKcpeZqYLrQk7Cp/Y=
Delivered-To: pkgsrc-changes%NetBSD.org@localhost
Received: from localhost (localhost [127.0.0.1])
by mail.netbsd.org (Postfix) with ESMTP id 2A968855C0
for <pkgsrc-changes%NetBSD.org@localhost>; Wed, 18 Sep 2024 09:17:31 +0000 (UTC)
X-Virus-Scanned: amavisd-new at netbsd.org
Authentication-Results: mail.netbsd.org (amavisd-new);
dkim=pass (1024-bit key) header.d=netbsd.org
Received: from mail.netbsd.org ([IPv6:::1])
by localhost (mail.netbsd.org [IPv6:::1]) (amavisd-new, port 10025)
with ESMTP id RqsRTY-nF3zx for <pkgsrc-changes%netbsd.org@localhost>;
Wed, 18 Sep 2024 09:17:30 +0000 (UTC)
Received: from cvs.NetBSD.org (ivanova.netbsd.org [199.233.217.197])
by mail.netbsd.org (Postfix) with ESMTP id 52CCE84CFE
for <pkgsrc-changes%NetBSD.org@localhost>; Wed, 18 Sep 2024 09:17:30 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netbsd.org;
s=20240131; t=1726651050;
bh=zjJ6o/Q8SA/uxcO9rmfHNoY15tNCyzmqpegqbunv2wo=;
h=Date:From:Subject:To:Reply-To;
b=a4yFSXYFNjFw1dl3m5SzqC2fsX/UOjUGh97pFKfWlDpRcyYPhCDDVq+UxJTj1Vsvq
NgR0ih4mrgwXeIiY9JrJ0eMGq6PMEJQppIvSfr13f7LirRRH22g85slkwjC88kI3Cx
2v+b6X2sqSrM/aej6eHAM4d4wzYqvr0PnAvY49jA=
Received: by cvs.NetBSD.org (Postfix, from userid 500)
id 4B2DAFC74; Wed, 18 Sep 2024 09:17:30 +0000 (UTC)
Content-Transfer-Encoding: 7bit
Content-Type: multipart/mixed; boundary="_----------=_1726651050101700"
MIME-Version: 1.0
Date: Wed, 18 Sep 2024 09:17:30 +0000
From: "Thomas Klausner" <wiz%netbsd.org@localhost>
Subject: CVS commit: pkgsrc/www/firefox102
To: pkgsrc-changes%NetBSD.org@localhost
Reply-To: wiz%netbsd.org@localhost
X-Mailer: log_accum
Message-Id: <20240918091730.4B2DAFC74%cvs.NetBSD.org@localhost>
Sender: pkgsrc-changes-owner%NetBSD.org@localhost
List-Id: <pkgsrc-changes.NetBSD.org>
Precedence: bulk
List-Unsubscribe: <mailto:majordomo%NetBSD.org@localhost?subject=Unsubscribe%20pkgsrc-changes&body=unsubscribe%20pkgsrc-changes>
This is a multi-part message in MIME format.
--_----------=_1726651050101700
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
Content-Type: text/plain; charset="US-ASCII"
Module Name: pkgsrc
Committed By: wiz
Date: Wed Sep 18 09:17:30 UTC 2024
Modified Files:
pkgsrc/www/firefox102: distinfo
Added Files:
pkgsrc/www/firefox102/patches:
patch-servo_components_style__traits_values.rs
patch-servo_ports_geckolib_cbindgen.toml
Log Message:
firefox102: apply cbindgen fix for 0.27 here as well
Still doesn't build for me though.
To generate a diff of this commit:
cvs rdiff -u -r1.18 -r1.19 pkgsrc/www/firefox102/distinfo
cvs rdiff -u -r0 -r1.1 \
pkgsrc/www/firefox102/patches/patch-servo_components_style__traits_values.rs \
pkgsrc/www/firefox102/patches/patch-servo_ports_geckolib_cbindgen.toml
Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.
--_----------=_1726651050101700
Content-Disposition: inline
Content-Length: 5938
Content-Transfer-Encoding: binary
Content-Type: text/x-diff; charset=us-ascii
Modified files:
Index: pkgsrc/www/firefox102/distinfo
diff -u pkgsrc/www/firefox102/distinfo:1.18 pkgsrc/www/firefox102/distinfo:1.19
--- pkgsrc/www/firefox102/distinfo:1.18 Fri May 10 09:14:07 2024
+++ pkgsrc/www/firefox102/distinfo Wed Sep 18 09:17:29 2024
@@ -1,4 +1,4 @@
-$NetBSD: distinfo,v 1.18 2024/05/10 09:14:07 jperkin Exp $
+$NetBSD: distinfo,v 1.19 2024/09/18 09:17:29 wiz Exp $
BLAKE2s (firefox-102.15.1esr.source.tar.xz) = 1dae9aa46405c07d2dcff2c0f74677925b646020c1722ff1034a39c2adb1e5bd
SHA512 (firefox-102.15.1esr.source.tar.xz) = bdb66b4fb5622af3e60580a3bcd464d98ef13cb38d6ac6c9e5fc046e567a003cf080125d7748950c91c442fde5e8024c50c4180d2f551aa3528160a3c05ae187
@@ -35,6 +35,8 @@ SHA1 (patch-modules_fdlibm_src_math__pri
SHA1 (patch-mozglue_misc_Uptime.cpp) = daefe25ef1ebc8e4d3735017b9e8ac68c4710a00
SHA1 (patch-nsprpub_pr_src_pthreads_ptsynch.c) = 13e512c7ee9fa1e14ba415d62fa853e5fbfc91c0
SHA1 (patch-security_nss_lib_freebl_mpi_mpi.c) = a7cd867916524770609d1c307a65b315b88456f4
+SHA1 (patch-servo_components_style__traits_values.rs) = 38b64d5a0edc3e9e94eafa1171cdb7b02e87ba2a
+SHA1 (patch-servo_ports_geckolib_cbindgen.toml) = b2a3b330666e1cd8d1e88fe760a1fea63fcef80c
SHA1 (patch-third__party_js_cfworker_build.sh) = 46cdf97b99cf01080f290ae8d9a33b5f869fc3e4
SHA1 (patch-third__party_libwebrtc_modules_video__capture_linux_device__info__linux.cc) = 2e951d7d91934751608e99628fc144632d8a3b5c
SHA1 (patch-third__party_libwebrtc_system__wrappers_source_cpu__features__linux.cc) = b90e22b50879f7adcc1da3a993f52c0701b720f8
Added files:
Index: pkgsrc/www/firefox102/patches/patch-servo_components_style__traits_values.rs
diff -u /dev/null pkgsrc/www/firefox102/patches/patch-servo_components_style__traits_values.rs:1.1
--- /dev/null Wed Sep 18 09:17:30 2024
+++ pkgsrc/www/firefox102/patches/patch-servo_components_style__traits_values.rs Wed Sep 18 09:17:30 2024
@@ -0,0 +1,47 @@
+$NetBSD: patch-servo_components_style__traits_values.rs,v 1.1 2024/09/18 09:17:30 wiz Exp $
+
+Bug 1912663 - Fix some build issues with cbindgen 0.27. r=firefox-style-system-reviewers,zrhoffman
+
+It updates serde and syn and they are more strict. In particular, syn 2
+doesn't parse the rust 2015 syntax where try is not a keyword, and serde
+rejects duplicate keys.
+
+Differential Revision: https://phabricator.services.mozilla.com/D219025
+
+--- servo/components/style_traits/values.rs.orig 2023-09-12 04:31:55.000000000 +0000
++++ servo/components/style_traits/values.rs
+@@ -374,11 +374,11 @@ impl Separator for Space {
+ where
+ F: for<'tt> FnMut(&mut Parser<'i, 'tt>) -> Result<T, ParseError<'i, E>>,
+ {
+- input.skip_whitespace(); // Unnecessary for correctness, but may help try() rewind less.
++ input.skip_whitespace(); // Unnecessary for correctness, but may help try_parse() rewind less.
+ let mut results = vec![parse_one(input)?];
+ loop {
+- input.skip_whitespace(); // Unnecessary for correctness, but may help try() rewind less.
+- if let Ok(item) = input.try(&mut parse_one) {
++ input.skip_whitespace(); // Unnecessary for correctness, but may help try_parse() rewind less.
++ if let Ok(item) = input.try_parse(&mut parse_one) {
+ results.push(item);
+ } else {
+ return Ok(results);
+@@ -399,14 +399,14 @@ impl Separator for CommaWithSpace {
+ where
+ F: for<'tt> FnMut(&mut Parser<'i, 'tt>) -> Result<T, ParseError<'i, E>>,
+ {
+- input.skip_whitespace(); // Unnecessary for correctness, but may help try() rewind less.
++ input.skip_whitespace(); // Unnecessary for correctness, but may help try_parse() rewind less.
+ let mut results = vec![parse_one(input)?];
+ loop {
+- input.skip_whitespace(); // Unnecessary for correctness, but may help try() rewind less.
++ input.skip_whitespace(); // Unnecessary for correctness, but may help try_parse() rewind less.
+ let comma_location = input.current_source_location();
+- let comma = input.try(|i| i.expect_comma()).is_ok();
+- input.skip_whitespace(); // Unnecessary for correctness, but may help try() rewind less.
+- if let Ok(item) = input.try(&mut parse_one) {
++ let comma = input.try_parse(|i| i.expect_comma()).is_ok();
++ input.skip_whitespace(); // Unnecessary for correctness, but may help try_parse() rewind less.
++ if let Ok(item) = input.try_parse(&mut parse_one) {
+ results.push(item);
+ } else if comma {
+ return Err(comma_location.new_unexpected_token_error(Token::Comma));
Index: pkgsrc/www/firefox102/patches/patch-servo_ports_geckolib_cbindgen.toml
diff -u /dev/null pkgsrc/www/firefox102/patches/patch-servo_ports_geckolib_cbindgen.toml:1.1
--- /dev/null Wed Sep 18 09:17:30 2024
+++ pkgsrc/www/firefox102/patches/patch-servo_ports_geckolib_cbindgen.toml Wed Sep 18 09:17:30 2024
@@ -0,0 +1,20 @@
+$NetBSD: patch-servo_ports_geckolib_cbindgen.toml,v 1.1 2024/09/18 09:17:30 wiz Exp $
+
+Bug 1912663 - Fix some build issues with cbindgen 0.27. r=firefox-style-system-reviewers,zrhoffman
+
+It updates serde and syn and they are more strict. In particular, syn 2
+doesn't parse the rust 2015 syntax where try is not a keyword, and serde
+rejects duplicate keys.
+
+Differential Revision: https://phabricator.services.mozilla.com/D219025
+
+--- servo/ports/geckolib/cbindgen.toml.orig 2023-09-12 04:31:55.000000000 +0000
++++ servo/ports/geckolib/cbindgen.toml
+@@ -293,7 +293,6 @@ renaming_overrides_prefixing = true
+ "nsChangeHint" = "nsChangeHint"
+ "ServoElementSnapshotTable" = "ServoElementSnapshotTable"
+ "nsTimingFunction" = "nsTimingFunction"
+-"Keyframe" = "Keyframe"
+ "ComputedKeyframeValues" = "ComputedKeyframeValues"
+ "OriginFlags" = "OriginFlags"
+ "ServoTraversalFlags" = "ServoTraversalFlags"
--_----------=_1726651050101700--
--bojaKrdHSQw321kl--
Home |
Main Index |
Thread Index |
Old Index