pkg/58544: st-0.9.1 doesn't correctly recognize Home/End/Del keys

[rvp%SDF.ORG@localhost]

>Number:         58544
>Category:       pkg
>Synopsis:       st-0.9.1 doesn't correctly recognize Home/End/Del keys
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Sat Aug 03 06:50:00 +0000 2024
>Originator:     RVP
>Release:        pkgsrc-2024Q2
>Organization:
>Environment:
NetBSD/amd64 10.99.11
>Description:
The `st-term' package, as it is compiled now, changes the reported terminal type
from the default `st-256color' to `xterm'. This causes weird issues in terminal
progs. like vi(1) when those keys are typed since the generated keys & the keycodes
in the terminfo database now don't match.
>How-To-Repeat:
Edit a file using vi(1) in st-0.9.1.
Try the std. (ie. _not_ the KP) Home/End/Del keys.
>Fix:
Don't force term type to `xterm'. 9.3 and all 10.x have a terminfo definition
for `st', `st-256color', etc.

```
--- Makefile.orig	2024-08-03 06:18:44.194617479 +0000
+++ Makefile	2024-08-03 06:22:52.810383239 +0000
@@ -27,7 +27,6 @@
 SUBST_MESSAGE.makefile=		Do not install the st terminfo entry
 SUBST_FILES.makefile=		Makefile
 SUBST_SED.configdefh+=		-e '/font/ s,".*","monospace:size=10",'
-SUBST_SED.configdefh+=		-e 's,st-256color,xterm,g'
 SUBST_SED.configmk+=		-e 's,/usr/local,${PREFIX},g'
 SUBST_SED.configmk+=		-e 's,share/man,${PKGMANDIR},g'
 SUBST_SED.configmk+=		-e 's,/usr/X11R6,${X11BASE},g'
```