Re: pkg/58450 (multimedia/liboggz has broken doc option)

[Rob Whitlock <rwhitlock22%gmail.com@localhost>]

The following reply was made to PR pkg/58450; it has been noted by GNATS.

From: Rob Whitlock <rwhitlock22%gmail.com@localhost>
To: gnats-bugs%netbsd.org@localhost
Cc: pkg-manager%netbsd.org@localhost,
 pkgsrc-bugs%netbsd.org@localhost,
 gnats-admin%netbsd.org@localhost,
 "wiz%netbsd.org@localhost" <wiz%NetBSD.org@localhost>
Subject: Re: pkg/58450 (multimedia/liboggz has broken doc option)
Date: Fri, 2 Aug 2024 10:38:32 -0400

 --Apple-Mail=_AFBEF4B3-8CB5-42F3-B41B-AEB2CB50821F
 Content-Transfer-Encoding: quoted-printable
 Content-Type: text/plain;
 	charset=us-ascii
 
 > On Jul 22, 2024, at 3:26 AM, wiz%netbsd.org@localhost <wiz%NetBSD.org@localhost> wrote:
 >=20
 > Synopsis: multimedia/liboggz has broken doc option
 >=20
 > State-Changed-From-To: open->closed
 > State-Changed-By: wiz%NetBSD.org@localhost
 > State-Changed-When: Mon, 22 Jul 2024 07:26:48 +0000
 > State-Changed-Why:
 > Fixed it so that disabling the option works. Thanks for the PR!
 
 Changing HAVE_OXYGEN=3Dno to HAVE_DOXYGEN=3Dfalse was one thing I didn't =
 catch, but there are still PLIST issues when building with the doc =
 option. Below is a patch that fixes the problem and keeps the status =
 quo; the documentation that does not require doxygen is still installed =
 when the doc option is not enabled, and when the doc option is enabled, =
 doxygen is pulled in and the doxygen generated documentation is also =
 installed.
 
 
 --Apple-Mail=_AFBEF4B3-8CB5-42F3-B41B-AEB2CB50821F
 Content-Disposition: attachment;
 	filename=liboggz.patch
 Content-Type: application/octet-stream;
 	x-unix-mode=0644;
 	name="liboggz.patch"
 Content-Transfer-Encoding: 7bit
 
 Index: PLIST
 ===================================================================
 RCS file: /cvsroot/pkgsrc/multimedia/liboggz/PLIST,v
 retrieving revision 1.1
 diff -b -u -r1.1 PLIST
 --- PLIST	9 May 2013 00:40:12 -0000	1.1
 +++ PLIST	2 Aug 2024 14:26:19 -0000
 @@ -42,32 +42,13 @@
  man/man1/oggz.1
  share/doc/liboggz/html/annotated.html
  ${PLIST.doc}share/doc/liboggz/html/bc_s.png
 -${PLIST.doc}share/doc/liboggz/html/bdwn.png
  share/doc/liboggz/html/classes.html
  ${PLIST.doc}share/doc/liboggz/html/closed.png
 -${PLIST.doc}share/doc/liboggz/html/dir_000000.html
 -${PLIST.doc}share/doc/liboggz/html/dir_000001.html
  share/doc/liboggz/html/doxygen.css
  share/doc/liboggz/html/doxygen.png
  ${PLIST.doc}share/doc/liboggz/html/dynsections.js
  share/doc/liboggz/html/files.html
  ${PLIST.doc}share/doc/liboggz/html/forcefeed.png
 -${PLIST.doc}share/doc/liboggz/html/ftv2blank.png
 -${PLIST.doc}share/doc/liboggz/html/ftv2cl.png
 -${PLIST.doc}share/doc/liboggz/html/ftv2doc.png
 -${PLIST.doc}share/doc/liboggz/html/ftv2folderclosed.png
 -${PLIST.doc}share/doc/liboggz/html/ftv2folderopen.png
 -${PLIST.doc}share/doc/liboggz/html/ftv2lastnode.png
 -${PLIST.doc}share/doc/liboggz/html/ftv2link.png
 -${PLIST.doc}share/doc/liboggz/html/ftv2mlastnode.png
 -${PLIST.doc}share/doc/liboggz/html/ftv2mnode.png
 -${PLIST.doc}share/doc/liboggz/html/ftv2mo.png
 -${PLIST.doc}share/doc/liboggz/html/ftv2node.png
 -${PLIST.doc}share/doc/liboggz/html/ftv2ns.png
 -${PLIST.doc}share/doc/liboggz/html/ftv2plastnode.png
 -${PLIST.doc}share/doc/liboggz/html/ftv2pnode.png
 -${PLIST.doc}share/doc/liboggz/html/ftv2splitbar.png
 -${PLIST.doc}share/doc/liboggz/html/ftv2vertline.png
  share/doc/liboggz/html/functions.html
  share/doc/liboggz/html/functions_vars.html
  share/doc/liboggz/html/globals.html
 @@ -136,8 +117,6 @@
  share/doc/liboggz/html/tabs.css
  share/doc/liboggz/latex/Makefile
  share/doc/liboggz/latex/annotated.tex
 -${PLIST.doc}share/doc/liboggz/latex/dir_000000.tex
 -${PLIST.doc}share/doc/liboggz/latex/dir_000001.tex
  share/doc/liboggz/latex/doxygen.sty
  share/doc/liboggz/latex/files.tex
  ${PLIST.doc}share/doc/liboggz/latex/forcefeed.eps
 @@ -172,3 +151,49 @@
  share/doc/liboggz/latex/structOggzComment.tex
  share/doc/liboggz/latex/structoggz__packet.tex
  share/doc/liboggz/latex/structoggz__position.tex
 +${PLIST.doc}share/doc/liboggz/html/bc_sd.png
 +${PLIST.doc}share/doc/liboggz/html/clipboard.js
 +${PLIST.doc}share/doc/liboggz/html/dir_26974de56ffe22e0ef3b764e67ab9f33.html
 +${PLIST.doc}share/doc/liboggz/html/dir_d436eb0fd9de10b54a828ce6435f7e81.html
 +${PLIST.doc}share/doc/liboggz/html/doc.svg
 +${PLIST.doc}share/doc/liboggz/html/docd.svg
 +${PLIST.doc}share/doc/liboggz/html/doxygen.svg
 +${PLIST.doc}share/doc/liboggz/html/doxygen_crawl.html
 +${PLIST.doc}share/doc/liboggz/html/folderclosed.svg
 +${PLIST.doc}share/doc/liboggz/html/folderclosedd.svg
 +${PLIST.doc}share/doc/liboggz/html/folderopen.svg
 +${PLIST.doc}share/doc/liboggz/html/folderopend.svg
 +${PLIST.doc}share/doc/liboggz/html/menu.js
 +${PLIST.doc}share/doc/liboggz/html/menudata.js
 +${PLIST.doc}share/doc/liboggz/html/minus.svg
 +${PLIST.doc}share/doc/liboggz/html/minusd.svg
 +${PLIST.doc}share/doc/liboggz/html/nav_fd.png
 +${PLIST.doc}share/doc/liboggz/html/nav_hd.png
 +${PLIST.doc}share/doc/liboggz/html/navtree.css
 +${PLIST.doc}share/doc/liboggz/html/plus.svg
 +${PLIST.doc}share/doc/liboggz/html/plusd.svg
 +${PLIST.doc}share/doc/liboggz/html/resize.js
 +${PLIST.doc}share/doc/liboggz/html/splitbar.png
 +${PLIST.doc}share/doc/liboggz/html/splitbard.png
 +${PLIST.doc}share/doc/liboggz/html/tab_ad.png
 +${PLIST.doc}share/doc/liboggz/html/tab_bd.png
 +${PLIST.doc}share/doc/liboggz/html/tab_hd.png
 +${PLIST.doc}share/doc/liboggz/html/tab_sd.png
 +${PLIST.doc}share/doc/liboggz/html/topics.html
 +${PLIST.doc}share/doc/liboggz/latex/etoc_doxygen.sty
 +${PLIST.doc}share/doc/liboggz/latex/longtable_doxygen.sty
 +${PLIST.doc}share/doc/liboggz/latex/oggz_8h_source.tex
 +${PLIST.doc}share/doc/liboggz/latex/oggz__comments_8h_source.tex
 +${PLIST.doc}share/doc/liboggz/latex/oggz__constants_8h_source.tex
 +${PLIST.doc}share/doc/liboggz/latex/oggz__deprecated_8h_source.tex
 +${PLIST.doc}share/doc/liboggz/latex/oggz__io_8h_source.tex
 +${PLIST.doc}share/doc/liboggz/latex/oggz__off__t_8h_source.tex
 +${PLIST.doc}share/doc/liboggz/latex/oggz__off__t__generated_8h_source.tex
 +${PLIST.doc}share/doc/liboggz/latex/oggz__packet_8h_source.tex
 +${PLIST.doc}share/doc/liboggz/latex/oggz__read_8h_source.tex
 +${PLIST.doc}share/doc/liboggz/latex/oggz__seek_8h_source.tex
 +${PLIST.doc}share/doc/liboggz/latex/oggz__stream_8h_source.tex
 +${PLIST.doc}share/doc/liboggz/latex/oggz__table_8h_source.tex
 +${PLIST.doc}share/doc/liboggz/latex/oggz__write_8h_source.tex
 +${PLIST.doc}share/doc/liboggz/latex/tabu_doxygen.sty
 +${PLIST.doc}share/doc/liboggz/latex/topics.tex
 
 --Apple-Mail=_AFBEF4B3-8CB5-42F3-B41B-AEB2CB50821F--