pkg/58535: devel/binutils can't install on Linux

[phil+netbsd%krylov.eu@localhost]

>Number:         58535
>Category:       pkg
>Synopsis:       devel/binutils can't install on Linux
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Thu Aug 01 23:20:00 +0000 2024
>Originator:     Phil Krylov
>Release:        pkgsrc-current
>Organization:
krylov.eu
>Environment:
Linux localhost.localdomain 3.10.0-1160.119.1.el7.x86_64 #1 SMP Tue Jun 4 14:43:51 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
>Description:
devel/binutils install fails on Linux, e.g.:

https://us-central.manta.mnx.io/pkgsrc/public/reports/Linux/el9/trunk/x86_64/20240730.2217/binutils-2.41/install.log


>How-To-Repeat:
bmake -c devel/binutils bin-install
>Fix:
Index: devel/binutils/Makefile
===================================================================
RCS file: /cvsroot/pkgsrc/devel/binutils/Makefile,v
retrieving revision 1.113
diff -p -u -r1.113 Makefile
--- devel/binutils/Makefile	28 Aug 2023 15:09:33 -0000	1.113
+++ devel/binutils/Makefile	1 Aug 2024 23:07:32 -0000
@@ -47,7 +47,7 @@ INSTALLATION_DIRS=	${PKGGNUDIR}bin ${PKG
 #
 # Supported utils and libraries differ quite a bit across platforms.
 #
-PLIST_VARS+=	ctf gas gold gprof ld
+PLIST_VARS+=	ctf gas gold gprof gprofng ld
 
 .include "../../mk/bsd.prefs.mk"
 
@@ -68,6 +68,16 @@ PLIST.gas=	yes
 PLIST.gprof=	yes
 .endif
 
+.if ${OPSYS} == "Linux"
+# libsframe needs explicit --enable-shared
+CONFIGURE_ARGS+=	--enable-shared
+CONFIGURE_ARGS+=	--sysconfdir=${PKG_SYSCONFDIR}
+EGDIR=			${PREFIX}/share/examples/binutils
+CONF_FILES=		${EGDIR}/gprofng.rc ${PKG_SYSCONFDIR}/gprofng.rc
+INSTALLATION_DIRS+=	${EGDIR}
+PLIST.gprofng=		yes
+.endif
+
 #
 # The PLIST.ld variable controls whether we install "ld -> gld" symlinks.  They
 # are excluded on SunOS to avoid accidentally using the wrong "ld", and on
@@ -98,7 +108,10 @@ CFLAGS+=	-Wno-unused-value -Wno-format-s
 .include "options.mk"
 
 SYMLINK_FILES=	addr2line ar ${PLIST.gas:Das} c++filt dlltool elfedit \
-		${PLIST.gprof:Dgprof} ${PLIST.ld:Dld} ${PLIST.gld:Dld.bfd} \
+		${PLIST.gprofng:Dgp-archive gp-collect-app gp-display-html gp-display-src gp-display-text} \
+		${PLIST.gprof:Dgprof} \
+		${PLIST.gprofng:Dgprofng} \
+		${PLIST.ld:Dld} ${PLIST.gld:Dld.bfd} \
 		${PLIST.gold:Dld.gold dwp} nlmconv nm objcopy objdump \
 		ranlib readelf size strings strip windmc windres
 
@@ -117,6 +130,8 @@ post-install:
 	              ${DESTDIR}${PREFIX}/${PKGGNUDIR}${PKGMANDIR}/man1/${f}.1; \
 	fi
 .endfor
-
+	if [ -f ${DESTDIR}${PREFIX}/etc/gprofng.rc ]; then \
+	    ${MV} ${DESTDIR}${PREFIX}/etc/* ${DESTDIR}${EGDIR}/; \
+	fi
 .include "../../mk/dlopen.buildlink3.mk"
 .include "../../mk/bsd.pkg.mk"
Index: devel/binutils/PLIST.common
===================================================================
RCS file: /cvsroot/pkgsrc/devel/binutils/PLIST.common,v
retrieving revision 1.41
diff -p -u -r1.41 PLIST.common
--- devel/binutils/PLIST.common	31 Jul 2023 14:08:34 -0000	1.41
+++ devel/binutils/PLIST.common	1 Aug 2024 23:07:32 -0000
@@ -16,7 +16,13 @@ ${PLIST.gas}bin/gas
 bin/gc++filt
 ${PLIST.gold}bin/gdwp
 bin/gelfedit
+${PLIST.gprofng}bin/ggp-archive
+${PLIST.gprofng}bin/ggp-collect-app
+${PLIST.gprofng}bin/ggp-display-html
+${PLIST.gprofng}bin/ggp-display-src
+${PLIST.gprofng}bin/ggp-display-text
 ${PLIST.gprof}bin/ggprof
+${PLIST.gprofng}bin/ggprofng
 ${PLIST.gld}bin/gld
 ${PLIST.gld}bin/gld.bfd
 ${PLIST.gold}bin/gld.gold
@@ -34,7 +40,13 @@ ${PLIST.gas}gnu/bin/as
 gnu/bin/c++filt
 ${PLIST.gold}gnu/bin/dwp
 gnu/bin/elfedit
+${PLIST.gprofng}gnu/bin/gp-archive
+${PLIST.gprofng}gnu/bin/gp-collect-app
+${PLIST.gprofng}gnu/bin/gp-display-html
+${PLIST.gprofng}gnu/bin/gp-display-src
+${PLIST.gprofng}gnu/bin/gp-display-text
 ${PLIST.gprof}gnu/bin/gprof
+${PLIST.gprofng}gnu/bin/gprofng
 ${PLIST.ld}gnu/bin/ld
 ${PLIST.gld}gnu/bin/ld.bfd
 ${PLIST.gold}gnu/bin/ld.gold
@@ -67,10 +79,13 @@ gnu/man/man1/windres.1
 include/ansidecl.h
 include/bfd.h
 include/bfdlink.h
+${PLIST.gprofng}include/collectorAPI.h
 ${PLIST.ctf}include/ctf-api.h
 ${PLIST.ctf}include/ctf.h
 include/diagnostics.h
 include/dis-asm.h
+${PLIST.gprofng}include/libcollector.h
+${PLIST.gprofng}include/libfcollector.h
 include/plugin-api.h
 include/sframe-api.h
 include/sframe.h
@@ -84,11 +99,16 @@ ${PLIST.gld}info/ld.info
 info/ldint.info
 info/sframe-spec.info
 ${PLIST.gld}lib/bfd-plugins/libdep.so
+${PLIST.gprofng}lib/gprofng/libgp-collector.so
+${PLIST.gprofng}lib/gprofng/libgp-collectorAPI.la
+${PLIST.gprofng}lib/gprofng/libgp-heap.so
+${PLIST.gprofng}lib/gprofng/libgp-iotrace.so
+${PLIST.gprofng}lib/gprofng/libgp-sync.so
 lib/libbfd.la
 ${PLIST.ctf}lib/libctf-nobfd.la
 ${PLIST.ctf}lib/libctf.la
+${PLIST.gprofng}lib/libgprofng.la
 lib/libopcodes.la
-lib/libsframe.a
 lib/libsframe.la
 man/man1/gaddr2line.1
 man/man1/gar.1