Re: pkg/58502: devel/patchelf binary package on CentOS 7 should depend on gcc8-libs

[Phil Krylov <phil+netbsd%krylov.eu@localhost>]

The following reply was made to PR pkg/58502; it has been noted by GNATS.

From: Phil Krylov <phil+netbsd%krylov.eu@localhost>
To: gnats-bugs%netbsd.org@localhost
Cc: 
Subject: Re: pkg/58502: devel/patchelf binary package on CentOS 7 should
 depend on gcc8-libs
Date: Thu, 01 Aug 2024 02:45:10 +0200

 Oops! I have revisited the patch and corrected it again:
 
 diff -p -u -r1.98 Makefile
 --- lang/llvm/Makefile	6 Jul 2024 15:45:05 -0000	1.98
 +++ lang/llvm/Makefile	1 Aug 2024 00:41:40 -0000
 @@ -128,6 +128,18 @@ PLIST_SUBST+=	RELEASE_TYPE=${RELEASE_TYP
   CMAKE_ARGS+=	-DPKGSRC_LLVM_PTHREADLIB=-lpthread
   .endif
 
 +# This package will link against libstdc++.so from the pkgsrc GCC when 
 the
 +# base OS GCC doesn't meet the minimum requirement. Thus we do this so 
 the
 +# appropriate gcc-libs package will be captured as a dependency, 
 otherwise
 +# binary packages will be broken.
 +# rustc: /lib64/libstdc++.so.6: version `GLIBCXX_3.4.22' not found 
 (required by /usr/pkg/lib/libLLVM.so.18.1)
 +.if ${OPSYS} == "Linux"
 +OPSYS_LIBSTDCXX_VERSIONS_CMD=	objdump -p 
 ${_OPSYS_LIB_DIRS:=/libstdc++.so.*} 2>/dev/null | grep -o 
 'GLIBCXX_[0-9.]*'
 +.  if empty(OPSYS_LIBSTDCXX_VERSIONS_CMD:sh:MGLIBCXX_3.4.22)
 +USE_PKGSRC_GCC_RUNTIME=	yes
 +.  endif
 +.endif
 +
   .if ${USE_CROSS_COMPILE:U:tl} == "yes"
   TOOL_DEPENDS+=	${PKGNAME}:../../${PKGPATH}
   CMAKE_ARGS+=	-DLLVM_TABLEGEN:STRING=${TOOLBASE:Q}/bin/llvm-tblgen