Re: pkg/58448: databases/sqlite3 is missing dbstat option

[Taylor R Campbell <riastradh%NetBSD.org@localhost>]

I note Debian ships sqlite3 with the following options enabled:

export CFLAGS += -O2 -fno-strict-aliasing \
        -DSQLITE_SECURE_DELETE -DSQLITE_ENABLE_COLUMN_METADATA \
        -DSQLITE_ENABLE_FTS3 -DSQLITE_ENABLE_FTS3_PARENTHESIS \
        -DSQLITE_ENABLE_RTREE=1 -DSQLITE_SOUNDEX=1 \
        -DSQLITE_ENABLE_UNLOCK_NOTIFY \
        -DSQLITE_ENABLE_DBSTAT_VTAB \
        -DSQLITE_ALLOW_ROWID_IN_VIEW \
        -DSQLITE_ENABLE_UPDATE_DELETE_LIMIT=1 \
        -DSQLITE_ENABLE_LOAD_EXTENSION \
        -DSQLITE_ENABLE_JSON1 \
        -DSQLITE_LIKE_DOESNT_MATCH_BLOBS \
        -DSQLITE_THREADSAFE=1 \
        -DSQLITE_ENABLE_FTS3_TOKENIZER=1 \
        -DSQLITE_USE_URI=1 \
        -DSQLITE_MAX_SCHEMA_RETRY=25 \
        -DSQLITE_ENABLE_PREUPDATE_HOOK \
        -DSQLITE_ENABLE_SESSION \
        -DSQLITE_ENABLE_STMTVTAB \
        -DSQLITE_STRICT_SUBTYPE=1 \
        -DSQLITE_MAX_VARIABLE_NUMBER=250000

Maybe we should follow suit with most of these, so that when you
install the sqlite3 package for the sqlite3 shell you get something
batteries-included, while applications that embed sqlite3 may keep it
stripped down.

Full list of build options to consider:

https://sqlite.org/compile.html

Either way, we should have the rationale for the default set of
option written down somewhere obvious, like in comments in options.mk.