Re: pkg/58264: Enable FAILOVER_FETCH by default

[Rob Whitlock <rwhitlock22%gmail.com@localhost>]

> On May 16, 2024, at 8:35 PM, Jörg Sonnenberger <joerg%bec.de@localhost> wrote:
> On Friday, May 17, 2024 1:20:00=E2=80=AFAM GMT+2 rwhitlock22%gmail.com@localhost wrot=
> e:
>>> How-To-Repeat:
>> Read pkgsrc/mk/fetch/fetch.mk and discover that FAILOVER_FETCH needs to b=
> e defined for checksums to be checked.
> 
> That's not true. Distfiles are always checked (unless the check is explicit=
> ly
> disabled) in the "checksum" phase. With FAILOVER_FETCH, the check is
> earlier and the newly fetched file is thrown away if it doesn't match. So
> unless a mirror later in the list does have the correct file, it will try o=
> ver
> and over to fetch the url. Given that we have distfiles that are 100s of MB,
> that can waste a lot of network IO.
> 
> I'm not saying that the current default is the best, but your description
> is certainly not right and there is a purpose behind the current setting.
> 
> Joerg

Thanks for the clarification. I didn't think that it would be done in two places.

Having the "checksum" phase do it works for me. Unless someone else has a reason to make FAILOVER_FETCH the default, this PR can be closed.