pkg/57994: lang/swi-prolog-lite do not build on NetBSD 10

[schaecsn%gmx.net@localhost]

>Number:         57994
>Category:       pkg
>Synopsis:       lang/swi-prolog-lite do not build on NetBSD 10
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Sun Mar 03 17:25:00 +0000 2024
>Originator:     Stefan Schaeckeler
>Release:        pkgsrc-2023Q4 and pkgsrc "latest"
>Organization:
>Environment:
NetBSD netbsd 10.0_RC4 NetBSD 10.0_RC4 (GENERIC) #0: Sun Feb 18 08:20:49 PST 2024  root@netbsd:/usr/obj/sys/arch/amd64/compile/GENERIC amd64

>Description:
lang/swi-prolog-lite does not build on NetBSD 10 due to new openssl which does not define RSA_SSLV23_PADDING:

/var/tmp/pkgsrc/lang/swi-prolog-lite/work/swipl-8.0.2/packages/ssl/crypto4pl.c:851:69: error: 'RSA_SSLV23_PADDING' undeclared (first use in this function); did you mean 'RSA_X931_PADDING'?
  851 |     else if ( a == ATOM_sslv23  && mode == RSA_MODE )    *padding = RSA_SSLV23_PADDING;
      |                                                                     ^~~~~~~~~~~~~~~~~~
      |                                                                     RSA_X931_PADDING
/var/tmp/pkgsrc/lang/swi-prolog-lite/work/swipl-8.0.2/packages/ssl/crypto4pl.c:851:69: note: each undeclared identifier is reported only once for each function it appears in
/var/tmp/pkgsrc/lang/swi-prolog-lite/work/swipl-8.0.2/packages/ssl/crypto4pl.c: In function 'pl_ecdsa_sign':


The most recent stable swi-prolog version is 9.2.2. The most recent stable version that just builds without patches is 9.0.4. Tested on NetBSD 10_RC4 as well as NetBSD 9.3.

>How-To-Repeat:
Build lang/swi-prolog-lite on NetBSD 10.
>Fix:
Short term solution could be a bump up to 9.0.4, e.g.

Index: lang/swi-prolog-lite/Makefile.common
===================================================================
RCS file: /cvsroot/pkgsrc/lang/swi-prolog-lite/Makefile.common,v
retrieving revision 1.18
diff -u -p -r1.18 Makefile.common
--- lang/swi-prolog-lite/Makefile.common        10 Jul 2019 10:32:05 -0000      1.18
+++ lang/swi-prolog-lite/Makefile.common        3 Mar 2024 17:01:38 -0000
@@ -4,7 +4,7 @@
 # used by lang/swi-prolog-packages/Makefile
 # used by lang/swi-prolog-jpl/Makefile
 
-SWIPLVERS=             8.0.2
+SWIPLVERS=             9.0.4
 DISTNAME=              swipl-${SWIPLVERS}
 CATEGORIES=            lang
 MASTER_SITES=          https://www.swi-prolog.org/download/stable/src/
Index: lang/swi-prolog-lite/buildlink3.mk
===================================================================
RCS file: /cvsroot/pkgsrc/lang/swi-prolog-lite/buildlink3.mk,v
retrieving revision 1.14
diff -u -p -r1.14 buildlink3.mk
--- lang/swi-prolog-lite/buildlink3.mk  25 Feb 2019 15:20:44 -0000      1.14
+++ lang/swi-prolog-lite/buildlink3.mk  3 Mar 2024 17:01:38 -0000
@@ -5,7 +5,7 @@ BUILDLINK_TREE+=        swi-prolog-lite
 .if !defined(SWI_PROLOG_LITE_BUILDLINK3_MK)
 SWI_PROLOG_LITE_BUILDLINK3_MK:=
 
-BUILDLINK_API_DEPENDS.swi-prolog-lite+=        swi-prolog-lite>=8.0.1
+BUILDLINK_API_DEPENDS.swi-prolog-lite+=        swi-prolog-lite>=9.0.3
 BUILDLINK_PKGSRCDIR.swi-prolog-lite?=  ../../lang/swi-prolog-lite
 
 .endif # SWI_PROLOG_LITE_BUILDLINK3_MK


That requires quite some changes in PLIST as well.