Re: pkg/57445: firefox crashes on startup

[Taylor R Campbell <riastradh%NetBSD.org@localhost>]

The following reply was made to PR pkg/57445; it has been noted by GNATS.

From: Taylor R Campbell <riastradh%NetBSD.org@localhost>
To: gnats-bugs%NetBSD.org@localhost
Cc: 
Subject: Re: pkg/57445: firefox crashes on startup
Date: Thu, 1 Jun 2023 00:28:00 +0000

 This is a multi-part message in MIME format.
 --=_QJyEfqlAfncoM8fB56hLDQdX5vxg3caH
 
 I pushed some changes to add rtld debug messages about tls:
 
 https://mail-index.netbsd.org/source-changes/2023/05/31/msg145024.html
 
 Can you:
 
 1. recompile ld.elf_so with -DDEBUG -DRTLD_DEBUG_RELOC (not
    -DRTLD_DEBUG) and the attached patch (same as at
    https://mail-index.netbsd.org/pkgsrc-users/2023/05/31/msg037402.html);
 
 2. save output of `LD_DEBUG=1 firefox' with your patches (it will be
    verrrrrry verbose);
 
 3. share the result of grepping that output for the combination of
    (a) your debug messages, and
    (b) the string ` tls '; and
 
 4. share the output of `readelf -ld' and `readelf -r | grep tls' on:
    (a) firefox (the actual executable),
    (b) libxul.so or whatever it is,
    (c) libGL.so,
    (d) libEGL.so, and
    (e) libglapi.so?
 
 --=_QJyEfqlAfncoM8fB56hLDQdX5vxg3caH
 Content-Type: text/plain; charset="ISO-8859-1"; name="rtldtlshack"
 Content-Transfer-Encoding: quoted-printable
 Content-Disposition: attachment; filename="rtldtlshack.patch"
 
 diff --git a/libexec/ld.elf_so/arch/x86_64/mdreloc.c b/libexec/ld.elf_so/ar=
 ch/x86_64/mdreloc.c
 index a04c05ea0aa7..adbab16003a7 100644
 --- a/libexec/ld.elf_so/arch/x86_64/mdreloc.c
 +++ b/libexec/ld.elf_so/arch/x86_64/mdreloc.c
 @@ -227,7 +227,7 @@ _rtld_relocate_nonplt_objects(Obj_Entry *obj)
 =20
  		case R_TYPE(TPOFF64):
  			if (!defobj->tls_done &&
 -			    _rtld_tls_offset_allocate(obj))
 +			    _rtld_tls_offset_allocate(__UNCONST(defobj)))
  				return -1;
 =20
  			*where64 =3D (Elf64_Addr)(def->st_value -
 
 --=_QJyEfqlAfncoM8fB56hLDQdX5vxg3caH--