Re: pkg/56500: gnutls fails to build on Solaris 10 (pkcs11 test)

[Jonathan Perkin <jperkin%joyent.com@localhost>]

The following reply was made to PR pkg/56500; it has been noted by GNATS.

From: Jonathan Perkin <jperkin%joyent.com@localhost>
To: gnats-bugs%netbsd.org@localhost
Cc: pkg-manager%netbsd.org@localhost, gnats-admin%netbsd.org@localhost, pkgsrc-bugs%netbsd.org@localhost,
	pekdon%gmail.com@localhost
Subject: Re: pkg/56500: gnutls fails to build on Solaris 10 (pkcs11 test)
Date: Thu, 23 Dec 2021 13:16:00 +0000

 * On 2021-12-22 at 17:15 GMT, Claes Nästén wrote:
 
 > +# tests fails on missing strndup for Solaris < 5.11, disable
 > +.if ${OPSYS} == "SunOS" && ${OS_VARIANT} == "Solaris" && ${OS_VERSION} != "5.11"
 > +CONFIGURE_ARGS.SunOS+=         --disable-tests
 > +.endif
 
 A few improvements:
 
   * The OPSYS test here is superfluous as CONFIGURE_ARGS is already
     using OPSYSVARS to limit its setting to SunOS.
 
   * The OS_VARIANT test is superfluous as there are only Solaris releases
     for 5.10 or older, illumos and its distributions are for 5.11 only.
 
   * The OS_VERSION test can be improved by using OPSYS_VERSION which I 
     recently introduced.
 
 So I'd write it like this:
 
    .if ${OPSYS_VERSION} < 051100
    CONFIGURE_ARGS.SunOS+=	--disable-tests
    .endif
 
 Hope that's helpful,
 
 -- 
 Jonathan Perkin  -  Joyent, Inc.  -  www.joyent.com