Re: pkg/56488: Solaris 10 compile issues, stdbool.h requires c99

[Claes Nästén <pekdon%gmail.com@localhost>]

The following reply was made to PR pkg/56488; it has been noted by GNATS.

From: =?utf-8?q?Claes_N=C3=A4st=C3=A9n?= <pekdon%gmail.com@localhost>
To: gnats-bugs <gnats-bugs%netbsd.org@localhost>
Cc: 
Subject: Re: pkg/56488: Solaris 10 compile issues, stdbool.h requires c99
Date: Thu, 11 Nov 2021 11:07:09 +0100

 Excerpts from nia's message of 2021-11-10 23:05:01 +0000:
 > The following reply was made to PR pkg/56488; it has been noted by GNATS.
 > 
 > From: nia <nia%NetBSD.org@localhost>
 > To: gnats-bugs%netbsd.org@localhost
 > Cc: 
 > Subject: Re: pkg/56488: Solaris 10 compile issues, stdbool.h requires c99
 > Date: Wed, 10 Nov 2021 23:03:06 +0000
 > 
 >  On Tue, Nov 09, 2021 at 12:00:02PM +0000, Claes Nstn wrote:
 >  >  Using flex as an example, it seems to include stdbool.h in
 >  >  src/flexdef.h unconditionally even though it checks for stdbool.h in
 >  >  configure and continues without it, it seems.
 >  >  
 >  >  I'm attaching the work.log and config.log, as I'm unsure what else you
 >  >  need.
 >  >  
 >  >  Will rebuild some of the other packages, hopefully providing some more
 >  >  insights to whether or not setting c99 is the way to go or not.
 >  
 >  Thanks, I found the reference to stdbool.h in devel/flex and
 >  applied the fix. However, I can't find the references to
 >  stdbool by grepping the other examples you gave.
 >  
 
 And here from www/libpsl:
 
 Making all in src
 gmake[2]: Entering directory `/usr/pkgsrc/www/libpsl/work/libpsl-0.21.1/src'
 /usr/pkg.new/bin/python3.9 ./psl-make-dafsa --output-format=cxx+ "../list/public_suffix_list.dat" suffixes_dafsa.h
 /usr/sfw/bin/gmake  all-am
 gmake[3]: Entering directory `/usr/pkgsrc/www/libpsl/work/libpsl-0.21.1/src'
   CC       libpsl_la-psl.lo
 In file included from /usr/pkgsrc/www/libpsl/work/.buildlink/include/unistring/stdbool.h:4,
                  from /usr/pkgsrc/www/libpsl/work/.buildlink/include/unicase.h:33,
                  from psl.c:95:
 /usr/include/stdbool.h:42:2: #error "Use of <stdbool.h> is valid only in a c99 compilation environment."
 In file included from psl.c:95:
 /usr/pkgsrc/www/libpsl/work/.buildlink/include/unicase.h:390: error: syntax error before "bool"
 /usr/pkgsrc/www/libpsl/work/.buildlink/include/unicase.h:394: error: syntax error before "bool"
 /usr/pkgsrc/www/libpsl/work/.buildlink/include/unicase.h:398: error: syntax error before "bool"
 /usr/pkgsrc/www/libpsl/work/.buildlink/include/unicase.h:405: error: syntax error before "bool"
 /usr/pkgsrc/www/libpsl/work/.buildlink/include/unicase.h:409: error: syntax error before "bool"
 /usr/pkgsrc/www/libpsl/work/.buildlink/include/unicase.h:413: error: syntax error before "bool"
 /usr/pkgsrc/www/libpsl/work/.buildlink/include/unicase.h:420: error: syntax error before "bool"
 /usr/pkgsrc/www/libpsl/work/.buildlink/include/unicase.h:424: error: syntax error before "bool"
 /usr/pkgsrc/www/libpsl/work/.buildlink/include/unicase.h:428: error: syntax error before "bool"
 /usr/pkgsrc/www/libpsl/work/.buildlink/include/unicase.h:435: error: syntax error before "bool"
 /usr/pkgsrc/www/libpsl/work/.buildlink/include/unicase.h:439: error: syntax error before "bool"
 /usr/pkgsrc/www/libpsl/work/.buildlink/include/unicase.h:443: error: syntax error before "bool"
 /usr/pkgsrc/www/libpsl/work/.buildlink/include/unicase.h:454: error: syntax error before "bool"
 /usr/pkgsrc/www/libpsl/work/.buildlink/include/unicase.h:458: error: syntax error before "bool"
 /usr/pkgsrc/www/libpsl/work/.buildlink/include/unicase.h:462: error: syntax error before "bool"
 In file included from psl.c:96:
 /usr/pkgsrc/www/libpsl/work/.buildlink/include/unistr.h:724: error: syntax error before "u8_startswith"
 /usr/pkgsrc/www/libpsl/work/.buildlink/include/unistr.h:725: warning: data definition has no type or storage class
 /usr/pkgsrc/www/libpsl/work/.buildlink/include/unistr.h:727: error: syntax error before "u16_startswith"
 /usr/pkgsrc/www/libpsl/work/.buildlink/include/unistr.h:728: warning: data definition has no type or storage class
 /usr/pkgsrc/www/libpsl/work/.buildlink/include/unistr.h:730: error: syntax error before "u32_startswith"
 /usr/pkgsrc/www/libpsl/work/.buildlink/include/unistr.h:731: warning: data definition has no type or storage class
 /usr/pkgsrc/www/libpsl/work/.buildlink/include/unistr.h:735: error: syntax error before "u8_endswith"
 /usr/pkgsrc/www/libpsl/work/.buildlink/include/unistr.h:736: warning: data definition has no type or storage class
 /usr/pkgsrc/www/libpsl/work/.buildlink/include/unistr.h:738: error: syntax error before "u16_endswith"
 /usr/pkgsrc/www/libpsl/work/.buildlink/include/unistr.h:739: warning: data definition has no type or storage class
 /usr/pkgsrc/www/libpsl/work/.buildlink/include/unistr.h:741: error: syntax error before "u32_endswith"
 /usr/pkgsrc/www/libpsl/work/.buildlink/include/unistr.h:742: warning: data definition has no type or storage class
 psl.c: In function `psl_str_to_utf8lower':
 psl.c:1833: warning: passing arg 2 of `libiconv' from incompatible pointer type
 gmake[3]: *** [libpsl_la-psl.lo] Error 1
 gmake[3]: Leaving directory `/usr/pkgsrc/www/libpsl/work/libpsl-0.21.1/src'
 gmake[2]: *** [all] Error 2
 gmake[2]: Leaving directory `/usr/pkgsrc/www/libpsl/work/libpsl-0.21.1/src'
 gmake[1]: *** [all-recursive] Error 1
 gmake[1]: Leaving directory `/usr/pkgsrc/www/libpsl/work/libpsl-0.21.1'
 
 So seems to be the libunistring dependency that bring in stdbool into the mix here.