pkg/56101: pkg_install fails to build with GNU tsort

[simmonds%polymorphism.ca@localhost]

>Number:         56101
>Category:       pkg
>Synopsis:       pkg_install fails to build with GNU tsort
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Sun Apr 11 02:35:00 +0000 2021
>Originator:     Colin Simmonds
>Release:        pkgsrc from git commit c9535bd18052d21dbf13a7f3ca4b46d52d8d3e7f
>Organization:
>Environment:
Darwin mirage.local 20.3.0 Darwin Kernel Version 20.3.0: Thu Jan 21 00:06:51 PST 2021; root:xnu-7195.81.3~1/RELEASE_ARM64_T8101 arm64 arm64 MacBookAir10,1 Darwin
>Description:
I have the coreutils package installed and my PATH variable set to include its gnu/bin directory before the default pkgsrc one, such that the version of tsort found is the GNU one. With this configuration, the pkg_install package fails to build due to an unsupported option:

tsort: invalid option -- 'q'
Try 'tsort --help' for more information.

>How-To-Repeat:
$ export PATH=$LOCALBASE/gnu/bin
$ cd pkgtools/pkg_install
$ bmake
>Fix:
The workaround is to run bmake with the PATH set to not include the GNU bin directory.

A proper fix would involve updating the build script to avoid using tsort -q or force the use of the BSD version of it.