pkg/55936: lang/ocaml : default safe string breaks certain builds

[aza.sea.agenda%gmail.com@localhost]

>Number:         55936
>Category:       pkg
>Synopsis:       lang/ocaml : default safe string breaks certain builds
>Confidential:   no
>Severity:       serious
>Priority:       high
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Mon Jan 18 06:45:00 +0000 2021
>Originator:     Aleksey Arens
>Release:        pkgsrc-2020Q4
>Organization:
SEATTLE WA
>Environment:
NetBSD HOSTNAME_REDACTED 9.1_STABLE NetBSD 9.1_STABLE (GENERIC) #1: Sun Jan  3 20:58:50 UTC 2021  root@HOSTNAME_REDACTED:/usr/src/sys/arch/amd64/compile/obj/GENERIC amd64
>Description:
The ocaml compiler built from lang/ocaml has safe strings forced by default.  This makes the `-usafe-string' compiler command line option unavailable.  The lack of this option, in particular, breaks sysutils/xentools413.

Cf. https://github.com/ocaml/ocaml/pull/1859 and https://discuss.ocaml.org/t/ocaml-4-10-released/5194 for more info on the respective upstream change.

>How-To-Repeat:

>Fix:
A very basic fix is to add an additional `configure' argument, added upstream specifically for the purpose of evading this breaking change.

I suppose that encoding of this option is a reasonable solution, because strings are safe by default anyway.

For the longer term, I would suggest to consider keeping this change for a couple of releases, and adding a patch to sysutils/xentools413 to fix the issue.  Ocaml already has mutable strings (as `Bytes') defined in its standard library under a different module, so the amount of changes to xentools413 should not be extensive.

---8<---

RCS file: /cvsroot/pkgsrc/lang/ocaml/Makefile,v
retrieving revision 1.141
diff -u -r1.141 Makefile
--- Makefile	26 Dec 2020 08:36:18 -0000	1.141
+++ Makefile	18 Jan 2021 06:25:42 -0000
@@ -14,6 +14,8 @@
 USE_LIBTOOL=		yes
 USE_GNU_CONFIGURE_HOST=	no
 
+CONFIGURE_ARGS+=	--disable-force-safe-string
+
 #USE_GCC_RUNTIME=	yes
 
 PLIST_VARS+=	ocaml-stub ocaml-prof ocaml-opt ocaml-nat ocaml-spacetime \