Re: pkg/55809: Webalizer seqfaults on NetBSD 9.0 and NetBSD 9.1

[Adrian Immanuel Kieß <adrian%kiess.onl@localhost>]

The following reply was made to PR pkg/55809; it has been noted by GNATS.

From: Adrian Immanuel =?ISO-8859-1?Q?Kie=DF?= <adrian%kiess.onl@localhost>
To: gnats-bugs%netbsd.org@localhost
Cc: 
Subject: Re: pkg/55809: Webalizer seqfaults on NetBSD 9.0 and NetBSD 9.1
Date: Wed, 06 Jan 2021 11:52:50 +0100

 --=-blhdAcwCh+3QEDtd97Ny
 Content-Type: multipart/mixed; boundary="=-fYRbGeggKYqTTDGY3+Db"
 
 
 --=-fYRbGeggKYqTTDGY3+Db
 Content-Type: text/plain; charset="UTF-8"
 Content-Transfer-Encoding: quoted-printable
 
 Dear Maintainer,
 
 mlelstv and dave0 at the Freenode IRC channel #NetBSD helped me to
 debug this problem.
 
 We ran gdb against the core file of webalizer and spotted the error in
 the function update_history() from preserve.c.
 
 We replaced the memcpy() calls inside update_history() and
 get_history() with memmove.
 
 After these changes where made, the resulting webalizer binary ran
 without coredumping and produced the second month of history/usage
 statistics.
 
 I have attached the patch to preserve.c as attachment to this E-Mail.
 
 Sincerely,
 
 Adrian Kie=C3=9F
 
 --=-fYRbGeggKYqTTDGY3+Db
 Content-Disposition: attachment; filename="preserve.c.diff.txt"
 Content-Type: text/plain; name="preserve.c.diff.txt"; charset="UTF-8"
 Content-Transfer-Encoding: base64
 
 LS0tIHByZXNlcnZlLmMub3JpZwkyMDIxLTAxLTA2IDEwOjMxOjQ5LjY1MzMxOTY5NiArMDEwMAor
 KysgcHJlc2VydmUuYy5uZXcJMjAyMS0wMS0wNiAxMTo0MTo0OS4yNjg2NDcxMzcgKzAxMDAKQEAg
 LTEwOSw3ICsxMDksMTMgQEAgdm9pZCBnZXRfaGlzdG9yeSgpCiAgICAgICAgICAgICAgICAgICAg
 ICAgICB5ciA9IGhpc3RbaV0ueWVhcjsKICAgICAgICAgICAgICAgICAgICAgICAgIG10aD0gaGlz
 dFtpXS5tb250aCsxOwogICAgICAgICAgICAgICAgICAgICAgICAgaWYgKG10aD4xMikgeyBtdGg9
 MTsgeXIrKzsgfQotICAgICAgICAgICAgICAgICAgICAgICAgbWVtY3B5KCZoaXN0WzBdLCAmaGlz
 dFsxXSwgc2l6ZW9mKGhpc3RbMF0pKmkpOworCQkgICAgICAgICAgICAgICAgICAgIAorCQkJCQkJ
 CQkJCQkJLyoqCisJCQkJCQkJCQkJCQkqIG1lbWNweSBvZiBvdmVybGFwcGluZyBhcmd1bWVudHMg
 aXMgdW5kZWZpbmVkIGJlaGF2aW91ciAtLSBjaGFuZ2UgdG8gbWVtbW92ZQorCQkJCQkJCQkJCQkJ
 KgorICAgICAgICAgICAgICAgICAgICAgICAgKiBtZW1jcHkoJmhpc3RbMF0sICZoaXN0WzFdLCBz
 aXplb2YoaGlzdFswXSkqaSk7CisJCQkJCQkJCSAgICAgICAgKi8KKyAgICAgICAgICAgICAgICAg
 ICAgICAgIG1lbW1vdmUoJmhpc3RbMF0sICZoaXN0WzFdLCBzaXplb2YoaGlzdFswXSkqaSk7CiAg
 ICAgICAgICAgICAgICAgICAgICAgICBtZW1zZXQoJmhpc3RbaV0sIDAsIHNpemVvZihzdHJ1Y3Qg
 aGlzdF9yZWMpKTsKICAgICAgICAgICAgICAgICAgICAgICAgIGhpc3RbaV0ueWVhcj15cjsgaGlz
 dFtpXS5tb250aD1tdGg7IG4tLTsKICAgICAgICAgICAgICAgICAgICAgfQpAQCAtMjc3LDcgKzI4
 MywxMiBAQCB2b2lkIHVwZGF0ZV9oaXN0b3J5KCkKICAgICAgICAgICAgICAgICAgIHlyID0gaGlz
 dFtpXS55ZWFyOwogICAgICAgICAgICAgICAgICAgbXRoPSBoaXN0W2ldLm1vbnRoKzE7CiAgICAg
 ICAgICAgICAgICAgICBpZiAobXRoPjEyKSB7IG10aD0xOyB5cisrOyB9Ci0gICAgICAgICAgICAg
 ICAgICBtZW1jcHkoJmhpc3RbMF0sJmhpc3RbMV0sc2l6ZW9mKGhpc3RbMF0pKmkpOworICAgICAg
 ICAgICAgICAgICAgLyoqIAorCQkJCQkJCQkJICogbWVtY3B5IG9mIG92ZXJsYXBwaW5nIGFyZ3Vt
 ZW50cyBpcyB1bmRlZmluZWQgYmVoYXZpb3VyIC0tIGNoYW5nZSB0byBtZW1tb3ZlCisJCQkJCQkJ
 CQkgKgorCQkJCQkJCQkJICogbWVtY3B5KCZoaXN0WzBdLCZoaXN0WzFdLHNpemVvZihoaXN0WzBd
 KSppKTsKKwkJCQkJCQkJCSAqKi8KKwkJCQkJCQkJCW1lbW1vdmUoJmhpc3RbMF0sJmhpc3RbMV0s
 c2l6ZW9mKGhpc3RbMF0pKmkpOwogICAgICAgICAgICAgICAgICAgbWVtc2V0KCZoaXN0W2ldLCAw
 LCBzaXplb2Yoc3RydWN0IGhpc3RfcmVjKSk7CiAgICAgICAgICAgICAgICAgICBoaXN0W2ldLnll
 YXI9eXI7IGhpc3RbaV0ubW9udGg9bXRoOyBuLS07CiAgICAgICAgICAgICAgICB9Cg==
 
 
 --=-fYRbGeggKYqTTDGY3+Db--
 
 --=-blhdAcwCh+3QEDtd97Ny
 Content-Type: application/pgp-signature; name="signature.asc"
 Content-Description: This is a digitally signed message part
 Content-Transfer-Encoding: 7bit
 
 -----BEGIN PGP SIGNATURE-----
 
 iQEzBAABCgAdFiEE9UJkhUvo8iOqz0LX1CpGptGZGuAFAl/1loIACgkQ1CpGptGZ
 GuAP/AgAmOG46xTvdv0ApJ5HgKN8WyT26RgQCNNGkLxfpXt/pjx0w7NBmP8K2Qjg
 hjPXbao4IQRXhwtf69zV4o43x1lIzD9flHypoOkwaAPOMu72w0Q+OC/DFsSOo26L
 16WuJkfgNlwUw00SNHAaXTBjlJUoFxdrd7ANs5aZFxT2xN0LkeluEGJQMYygpHb/
 pbzV/XxEeWb2BT19R6BeAatZp4vuw/mnvJnDehVhuV6YAqQZQpCHpE9W/W8aS+4D
 CigJ6uhAuWqj5eO8S0iFvMso4yOxz4ibjhNonrKwophERdjDjZwILsosKqc9rU5d
 Y7zAmjHQrNogBN5p6sRWtVuUvuxMwg==
 =k4jK
 -----END PGP SIGNATURE-----
 
 --=-blhdAcwCh+3QEDtd97Ny--