pkg/55524: pkgtools/pkglint raises an error for paths containing /etc in patches

[triaxx%netbsd.org@localhost]

>Number:         55524
>Category:       pkg
>Synopsis:       pkgtools/pkglint raises an error for paths containing /etc in patches
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    pkg-manager
>State:          open
>Class:          change-request
>Submitter-Id:   net
>Arrival-Date:   Thu Jul 30 09:30:00 +0000 2020
>Originator:     Frédéric Fauberteau
>Release:        pkgsrc-HEAD
>Organization:
>Environment:
System: FreeBSD cocoon.triaxx.org 12.1-RELEASE-p7 FreeBSD 12.1-RELEASE-p7 GENERIC  amd64
Architecture: x86_64
Machine: amd64
>Description:
The following errors are raised for patch given below:
ERROR: patches/patch-src_daemon.c:22: Patches must not hard-code the pkgsrc PKG_SYSCONFDIR.
ERROR: patches/patch-src_daemon.c:35: Patches must not hard-code the pkgsrc PKG_SYSCONFDIR.

  1 $NetBSD: patch-src_daemon.c,v 1.1 2018/06/11 23:55:50 youri Exp $
  2 
  3 Add NetBSD backend inspired from OpenBSD ports.
  4 
  5 --- src/daemon.c.orig 2015-02-25 13:51:44.000000000 +0000
  6 +++ src/daemon.c
  7 @@ -29,6 +29,7 @@
  8  #include <fcntl.h>
  9  #include <sys/wait.h>
 10  #include <pwd.h>
 11 +#include <grp.h>
 12  #include <unistd.h>
 13  #include <errno.h>
 14  #include <sys/types.h>
 15 @@ -46,9 +47,13 @@
 16  #include "util.h"
 17 
 18  #define PATH_PASSWD "/etc/passwd"
 19 +#if defined(HAVE_SHADOW_H)
 20  #define PATH_SHADOW "/etc/shadow"
 21 +#elif defined(__NetBSD__) || defined(__FreeBSD__)
 22 +#define PATH_SHADOW "/etc/master.passwd"
 23 +#endif
 24  #define PATH_GROUP "/etc/group"
 25 -#define PATH_GDM_CUSTOM "/etc/gdm/custom.conf"
 26 +#define PATH_GDM_CUSTOM "@PKG_SYSCONFDIR@/gdm/custom.conf"
 27 
 28  enum {
 29          PROP_0,
 30 @@ -1083,6 +1088,34 @@ daemon_delete_user_authorized_cb (Daemon
 31                  return;
 32          }
 33 
 34 +/*
 35 + * Under NetBSD there is no /etc/login.defs (for USERGROUPS_ENAB), so
 36 + * we need to explicitely remove the user's group if it contains no more
 37 + * members and matches the username.
 38 + */
>How-To-Repeat:
>Fix: