Re: pkg/55217: devel/gobject-introspection breaks cwrappers LOCALBASE contains symlink

[Jonathan Perkin <jperkin%joyent.com@localhost>]

* On 2020-04-29 at 15:45 BST, Christos Zoulas wrote:

>  I think this should be enforced though (i.e. the pkgsrc Makefiles
>  should complain).  Otherwise some packages work, others don't which
>  is puzzling and seems like a mistake.

The bootstrap script does check, but it looks like it only checks when
the user has specified paths, not when they are using the defaults.

I'd recommend just adding a new $prefix check after setting
prefix=${HOME}/pkg.

The problem with the simple fix of just moving all the checks down to
after $prefix is set is that varbase=/var will fail the checks on
macOS where it is a symlink to /private/var.

I don't think having VARBASE be a symlink is a problem in practice,
the primary concerns are LOCALBASE and WRKOBJDIR.

-- 
Jonathan Perkin  -  Joyent, Inc.  -  www.joyent.com