[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]
PR/48587 CVS commit: pkgsrc/devel/libffi
The following reply was made to PR pkg/48587; it has been noted by GNATS.
From: "David Sainty" <dsainty%netbsd.org@localhost>
Subject: PR/48587 CVS commit: pkgsrc/devel/libffi
Date: Fri, 24 Apr 2020 10:19:32 +0000
Module Name: pkgsrc
Committed By: dsainty
Date: Fri Apr 24 10:19:32 UTC 2020
pkgsrc/devel/libffi: Makefile distinfo
Revert portions of PR/48587 - applied in 2014 to resolve some issue
with building on Irix. The changes applied to 'configure' introduce
some quite ugly quote nesting that not all shells (E.g. ksh) can
After discussion, prefer to roll back what looks like undesirable and
unnecessary changes, and drop the 'bash' dependency. My suspicion is
that the old 'configure' patch is unhelpful even for Irix.
The reason for the PR/48587 changes are not clear, given that part of
that patch also selected 'bash' as the shell to use - which should
have made editing the script unnecessary in the first place.
Demonstrating the problem bringing all this to attention, this is what
happens if you are using ksh as the Pkgsrc shell on MacOS X:
===> Building for libffi-3.3nb2
/bin/ksh: : cannot execute [Is a directory]
The cause is this ugly looking quote nesting that was introduced by
patch-configure in PR/48587...
$ BUILD="` grep "^#### $HOST " Makefile | sed -e 's/.*|//' `"
ksh: : cannot execute [Is a directory]
bash-5.0$ BUILD="` grep "^#### $$HOST " Makefile | sed -e 's/.*|//' `"
sh-3.2$ BUILD="` grep "^#### $$HOST " Makefile | sed -e 's/.*|//' `"
Removing patch-configure results in this much simpler, portable looking
$ BUILD=` grep "^#### $$HOST " Makefile | sed -e 's/.*|//' `
No PKGREVISION bump, this change is not anticipated to affect the
package contents, only the success or failure of the build.
To generate a diff of this commit:
cvs rdiff -u -r1.41 -r1.42 pkgsrc/devel/libffi/Makefile
cvs rdiff -u -r1.53 -r1.54 pkgsrc/devel/libffi/distinfo
cvs rdiff -u -r1.1 -r1.2 pkgsrc/devel/libffi/patches/patch-configure
Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.
Main Index |
Thread Index |