pkg/55078: graphics/gnuplot does not build with readline

[joern.clausen%uni-bielefeld.de@localhost]

>Number:         55078
>Category:       pkg
>Synopsis:       graphics/gnuplot does not build with readline
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Tue Mar 17 13:00:00 +0000 2020
>Originator:     Joern Clausen
>Release:        
>Organization:
Bielefeld University
>Environment:
>Description:
graphics/gnuplot fails to build when READLINE_DEFAULT is set to readline (instead of the default "editline") with

gcc -DHAVE_CONFIG_H -I. -I..  -I../term -I../term -DBINDIR=\"/usr/pkg/bin\" -DX11_DRIVER_DIR=\"/usr/pkg/libexec/gnuplot/5.2\" -DQT_DRIVER_DIR=\"/usr/pkg/libexec/gnuplot/5.2\" -DGNUPLOT_SHARE_DIR=\"/usr/pkg/share/gnuplot/5.2\" -DGNUPLOT_PS_DIR=\"/usr/pkg/share/gnuplot/5.2/PostScript\" -DGNUPLOT_JS_DIR=\"/usr/pkg/share/gnuplot/5.2/js\" -DGNUPLOT_LUA_DIR=\"/usr/pkg/share/gnuplot/5.2/lua\" -DCONTACT=\"gnuplot-bugs%lists.sourceforge.net@localhost\" -DHELPFILE=\"/usr/pkg/share/gnuplot/5.2/gnuplot.gih\" -DGNUPLOT_X11=\"`echo gnuplot_x11 | sed 's,x,x,'`\" -DXAPPLRESDIR=\"/etc/X11/app-defaults/\"   -I/usr/pkg/include -I/usr/include -I/usr/pkg/include/freetype2 -I/usr/pkg/include/glib-2.0 -I/usr/pkg/include/gio-unix-2.0 -I/usr/pkg/lib/glib-2.0/include -I/usr/pkg/include   -I/usr/pkg/include -I/usr/pkg/include/cairo -I/usr/pkg/include/pixman-1 -I/usr/pkg/include -I/usr/pkg/include/freetype2 -I/usr/pkg/include/uuid -I/usr/pkg/include/libpng16 -I/usr/pkg/include/pango-1.0 -I/usr/pkg/include/glib-2.0 -I/usr
 /pkg/lib/glib-2.0/include -I/usr/pkg/include/harfbuzz -I/usr/pkg/include/fribidi -D_REENTRANT   -O2 -D_FORTIFY_SOURCE=2 -I/usr/pkg/include -I/usr/include -I/usr/pkg/include/freetype2 -I/usr/pkg/include/glib-2.0 -I/usr/pkg/include/gio-unix-2.0 -I/usr/pkg/lib/glib-2.0/include -MT history.o -MD -MP -MF $depbase.Tpo -c -o history.o history.c &&\
mv -f $depbase.Tpo $depbase.Po
history.c:281:1: error: unknown type name 'histdata_t'; did you mean 'stack_t'?
 histdata_t
 ^~~~~~~~~~
 stack_t
history.c:282:20: error: unknown type name 'HIST_ENTRY'; did you mean 'KEYMAP_ENTRY'?
 free_history_entry(HIST_ENTRY *histent)
                    ^~~~~~~~~~
                    KEYMAP_ENTRY
history.c: In function 'gp_read_history':
history.c:381:7: warning: implicit declaration of function 'add_history'; did you mean 'cancel_history'? [-Wimplicit-function-declaration]
       add_history(pline);
       ^~~~~~~~~~~
       cancel_history
history.c: In function 'write_history_list':
history.c:404:11: error: unknown type name 'HIST_ENTRY'
     const HIST_ENTRY *list_entry;
           ^~~~~~~~~~


This happens on both NetBSD and Solaris, and is severe on Solaris, as editline currently does not build on that platform (see pkg/55064).
>How-To-Repeat:

>Fix: