Re: pkg/54907: openpam pam_unix 2019 missing -lcrypt in link

[Frédéric Fauberteau <triaxx%NetBSD.org@localhost>]

The following reply was made to PR pkg/54907; it has been noted by GNATS.

From: =?UTF-8?Q?Fr=C3=A9d=C3=A9ric_Fauberteau?= <triaxx%NetBSD.org@localhost>
To: gnats-bugs%netbsd.org@localhost
Cc: 
Subject: Re: pkg/54907: openpam pam_unix 2019 missing -lcrypt in link
Date: Thu, 30 Jan 2020 09:34:54 +0100

 The patch below add -lcrypt only for the pam_unix module.
 
 Index: distinfo
 ===================================================================
 RCS file: /cvsroot/pkgsrc/security/openpam/distinfo,v
 retrieving revision 1.14
 diff -u -r1.14 distinfo
 --- distinfo    30 Dec 2019 19:44:33 -0000      1.14
 +++ distinfo    30 Jan 2020 08:32:38 -0000
 @@ -8,3 +8,4 @@
   SHA1 (patch-lib_libpam_openpam__configure.c) = 
 5f4271121d03eb6b9ea7e3e1b85f9b27c9f4eaae
   SHA1 (patch-lib_libpam_openpam__constants.c) = 
 14b11cda3dbbfafd5a45865a868295e801bd1733
   SHA1 (patch-lib_libpam_openpam__dynamic.c) = 
 0bed21f16b74dbdb312ce4f09c17055a0891bdd5
 +SHA1 (patch-modules_pam__unix_Makefile.in) = 
 a8648e5384050f4d8b48ba426e74fee1a5555acb
 cvs diff: Diffing files
 cvs diff: Diffing patches
 Index: patches/patch-modules_pam__unix_Makefile.in
 ===================================================================
 RCS file: patches/patch-modules_pam__unix_Makefile.in
 diff -N patches/patch-modules_pam__unix_Makefile.in
 --- /dev/null   1 Jan 1970 00:00:00 -0000
 +++ patches/patch-modules_pam__unix_Makefile.in 30 Jan 2020 08:32:38 
 -0000
 @@ -0,0 +1,15 @@
 +$NetBSD$
 +
 +Make pam_unix.so module linked to libcrypt (PR pkg/54907).
 +
 +--- modules/pam_unix/Makefile.in.orig  2019-02-24 20:21:23.000000000 
 +0000
 ++++ modules/pam_unix/Makefile.in
 +@@ -340,7 +340,7 @@ AM_CPPFLAGS = -I$(top_srcdir)/include
 + module_LTLIBRARIES = pam_unix.la
 + pam_unix_la_SOURCES = pam_unix.c
 + pam_unix_la_LDFLAGS = -no-undefined -module -version-info $(LIB_MAJ) \
 +-      -export-symbols-regex '^pam_sm_'
 ++      -export-symbols-regex '^pam_sm_' -lcrypt
 +
 + @WITH_SYSTEM_LIBPAM_FALSE@pam_unix_la_LIBADD = 
 $(top_builddir)/lib/libpam/libpam.la $(CRYPT_LIBS)
 + @WITH_SYSTEM_LIBPAM_TRUE@pam_unix_la_LIBADD = $(SYSTEM_LIBPAM)