Re: pkg/54752: devel/glib2 does not build on FreeBSD

[Frédéric Fauberteau <triaxx%NetBSD.org@localhost>]

The following reply was made to PR pkg/54752; it has been noted by GNATS.

From: =?UTF-8?Q?Fr=C3=A9d=C3=A9ric_Fauberteau?= <triaxx%NetBSD.org@localhost>
To: gnats-bugs%netbsd.org@localhost
Cc: 
Subject: Re: pkg/54752: devel/glib2 does not build on FreeBSD
Date: Fri, 27 Dec 2019 23:39:52 +0100

 Clang leaves undefined the environ(7) symbol but it seems that it is 
 resolved when a binary is linked to glib2. The error occurs either using 
 the basesystem's Clang-6.0.1 or the pkgsrc's one (Clang-9.0.0). I do not 
 know if the problem comes from Clang of FreeBSD. The following patch fix 
 the build error:
 Index: Makefile
 ===================================================================
 RCS file: /cvsroot/pkgsrc/devel/glib2/Makefile,v
 retrieving revision 1.265
 diff -u -r1.265 Makefile
 --- Makefile    28 Nov 2019 09:23:32 -0000      1.265
 +++ Makefile    27 Dec 2019 22:34:35 -0000
 @@ -10,11 +10,15 @@
   MESON_ARGS+=   -Dinstalled_tests=false
   # Avoid linux dependency on libmount-dev
   MESON_ARGS+=   -Dlibmount=false
 +.if ${OPSYS} == "FreeBSD"
 +MESON_ARGS+=   -Db_lundef=false
 +.endif
 
   MAKE_ENV+=     
 LD_LIBRARY_PATH=${WRKSRC}/output/gio:${WRKSRC}/output/glib:${WRKSRC}/output/gobject:${WRKSRC}/output/gmodule
 
   CPPFLAGS.SunOS+=       -D_XOPEN_SOURCE=600 -D__EXTENSIONS__
   LDFLAGS.SunOS+=                -liconv -lintl -lnsl -lsocket
 +LDFLAGS.FreeBSD+=      -liconv
 
   REPLACE_PYTHON+=       gio/gio-querymodules-wrapper.py
   REPLACE_PYTHON+=       gio/tests/gengiotypefuncs.py