pkg/54722: devel/glib2 still does not compile on Solaris 11.3

[joern.clausen%uni-bielefeld.de@localhost]

>Number:         54722
>Category:       pkg
>Synopsis:       devel/glib2 still does not compile on Solaris 11.3
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Wed Nov 27 08:20:01 +0000 2019
>Originator:     Joern Clausen
>Release:        
>Organization:
Bielefeld University
>Environment:
>Description:
Compiling devel/glib2 on Solaris 11.3 with fairly recent patches fails with

gcc -Igio/6ae6c9e@@gio-2.0@sha -Igio -I../gio -I. -I../ -Iglib -I../glib -Igobject -I../gobject -Igmodule -I../gmodule -I/opt/pkg-hrz/201910
04/include -I/usr/include -I/opt/pkg-hrz/20191004/include/python3.7 -fdiagnostics-color=always -pipe -D_FILE_OFFSET_BITS=64 -std=gnu89 -D_GN
U_SOURCE -fno-strict-aliasing -Wall -Wduplicated-branches -Wimplicit-fallthrough -Wmisleading-indentation -Wstrict-prototypes -Wunused -Wno-
unused-parameter -Wno-bad-function-cast -Wno-cast-function-type -Wno-pedantic -Werror=declaration-after-statement -Werror=format=2 -Werror=i
mplicit-function-declaration -Werror=init-self -Werror=missing-include-dirs -Werror=missing-prototypes -Werror=pointer-arith -O2 -D_FORTIFY_
SOURCE=2 -fPIC -pthread '-DG_LOG_DOMAIN="GLib-GIO"' -DGIO_COMPILATION '-DGIO_MODULE_DIR="/opt/pkg-hrz/20191004/lib/gio/modules"' -fvisibilit
y=hidden -MD -MQ 'gio/6ae6c9e@@gio-2.0@sha/gsocket.c.o' -MF 'gio/6ae6c9e@@gio-2.0@sha/gsocket.c.o.d' -o 'gio/6ae6c9e@@gio-2.0@sha/gsocket.c.
o' -c ../gio/gsocket.c
../gio/gsocket.c: In function 'input_message_from_msghdr':
../gio/gsocket.c:4591:12: error: 'const struct msghdr' has no member named 'msg_controllen'
 4591 |     if (msg->msg_controllen >= sizeof (struct cmsghdr))
      |            ^~
../gio/gsocket.c:4594:21: error: implicit declaration of function 'CMSG_FIRSTHDR' [-Werror=implicit-function-declaration]
 4594 |         for (cmsg = CMSG_FIRSTHDR (msg);
      |                     ^~~~~~~~~~~~~

and several other unknown structs and defines.
>How-To-Repeat:

>Fix:
This change makes the package compile for me:

--- Makefile    2019/11/27 07:23:05     1.1
+++ Makefile    2019/11/27 08:13:27
@@ -13,6 +13,7 @@
 
 MAKE_ENV+=     LD_LIBRARY_PATH=${WRKSRC}/output/gio:${WRKSRC}/output/glib:${WRKSRC}/output/gobject:${WRKSRC}/output/gmodule
 
+CPPFLAGS.SunOS+=-D_XOPEN_SOURCE=1 -D_XOPEN_SOURCE_EXTENDED=1 -D__EXTENSIONS__
 LDFLAGS.SunOS+=                -liconv -lintl -lnsl -lsocket
 
 REPLACE_PYTHON+=       gio/gio-querymodules-wrapper.py