pkg/54629: devel/gmake circular dependency due to nls option and pkgsrc gettext

[triaxx%netbsd.org@localhost]

>Number:         54629
>Category:       pkg
>Synopsis:       devel/gmake circular dependency due to nls option and pkgsrc gettext
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Sun Oct 20 16:25:00 +0000 2019
>Originator:     Frédéric Fauberteau
>Release:        NetBSD 8.0 |Â pkgsrc-HEAD
>Organization:
>Environment:
System: NetBSD hydralisk.triaxx.org 8.0 NetBSD 8.0 (HYDRALISK) #0: Mon Jan  7 23:57:12 CET 2019  root%hydralisk.triaxx.org@localhost:/mnt/ccd0/netbsd/obj.amd64/sys/arch/amd64/compile/HYDRALISK amd64
Architecture: x86_64
Machine: amd64
>Description:
When we want to build devel/gmake with the "nls" option enabled and PREFER_PKGSRC set to "yes", a circular dependency occurs:
ERROR: This package has set PKG_FAIL_REASON:
ERROR: Circular dependency detected
*** Error code 1

Stop.
bmake[3]: stopped in /mnt/ccd0/pkgsrc/devel/gmake
*** Error code 1

Stop.
bmake[2]: stopped in /mnt/ccd0/pkgsrc/devel/ncurses
*** Error code 1

Stop.
bmake[1]: stopped in /mnt/ccd0/pkgsrc/devel/gettext-tools
*** Error code 1

Stop.
bmake: stopped in /usr/pkgsrc/devel/gmake
>How-To-Repeat:
cat >> /etc/mk.conf << EOF
PREFER_PKGSRC=yes
PKG_OPTIONS.gmake=nls
EOF
cd devel/gmake && bmake
>Fix:
===================================================================
RCS file: /cvsroot/pkgsrc/devel/gmake/options.mk,v
retrieving revision 1.3
diff -u -r1.3 options.mk
--- options.mk	1 Jan 2016 01:42:53 -0000	1.3
+++ options.mk	20 Oct 2019 16:20:33 -0000
@@ -3,15 +3,18 @@
 PKG_OPTIONS_VAR=	PKG_OPTIONS.gmake
 PKG_SUPPORTED_OPTIONS=	nls
 
-PKG_OPTIONS_LEGACY_VARS+=	GMAKE_LOCALE
+PLIST_VARS+=		nls
 
 .include "../../mk/bsd.options.mk"
 
-.if !empty(PKG_OPTIONS:Mnls)
-USE_PKGLOCALEDIR=		yes
-PLIST_SRC+=			${PKGDIR}/PLIST.locale
-USE_TOOLS+=			msgfmt
+.include "../../devel/gettext-lib/builtin.mk"
+.if !empty(PKG_OPTIONS:Mnls) && \
+    !empty(IS_BUILTIN.gettext:M[yY][eE][sS])
+USE_PKGLOCALEDIR=	yes
+USE_TOOLS+=		msgfmt
+PREFER.gettext=		native
 .  include "../../devel/gettext-lib/buildlink3.mk"
+PLIST.nls=		yes
 .else
 CONFIGURE_ARGS+=	--without-libintl-prefix
 CONFIGURE_ARGS+=	--without-libiconv-prefix